Merged
Conversation
Member
|
We reverted theming the new Move static members dialog (#56013) and will update your feature branch with our changes once it is merged to dev17.1. |
JoeRobich
approved these changes
Jul 6, 2022
Comment on lines
+54
to
+57
| <Style TargetType="DataGridColumnHeader" BasedOn="{StaticResource {x:Type DataGridColumnHeader}}"> | ||
| <Setter Property="Foreground" Value="{DynamicResource {x:Static vsshell:VsBrushes.ToolWindowTextKey}}" /> | ||
| <Setter Property="Background" Value="{DynamicResource {x:Static vsui:HeaderColors.DefaultBrushKey}}" /> | ||
| <Setter Property="BorderBrush" Value="{DynamicResource {x:Static vsui:HeaderColors.SeparatorLineBrushKey}}" /> |
Member
There was a problem hiding this comment.
Does this theme the Sort arrow in the header?
Contributor
Author
There was a problem hiding this comment.
I'm not sure the sort arrow is done here, this should be for the header's border around the cell. Need to double check if arrows are broken by this.
| </StackPanel> | ||
| </Grid> | ||
|
|
||
| <ContentPresenter Content="{Binding ElementName=dialog, Path=MemberSelectionControl}" Margin="9, 9, 9, 7" /> |
adamperlin
pushed a commit
to adamperlin/roslyn
that referenced
this pull request
Jul 19, 2022
Theme dialogs to be consistent with VS theming. This adds a resource dictionary that can be used to cover _most_ scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme pull members up, extract interface, and extract class.
Extract Class
Extract Interface
Pull Members Up