Enable add usings on paste by default#61299
Conversation
dibarbet
left a comment
There was a problem hiding this comment.
is the plan to entirely remove the option in 17.4?
Maybe... We'll have to discuss that. I could still see this behavior being undesirable to some people. We should bring it up in a design meeting though and see what the team thinks. |
Good question. I could see people never wanting this feature and potentially disabling it. I've even noticed it a few times when it popped up and i didn't need it. It didn't hugely bother me, but it might for other people. |
Currently working on a PR to help here.
I'm always hesitant to make things like this not configurable since it is visual noise and potentially modifying code for a user in a way they can't readily see. It would be similar to having to undo IntelliCode suggestions every time or something.... There's a lot of impact here for various user groups that could be VERY negative. |
Oh? What are you thinking about? |
As long as the feature is only an approximation of correct (which it is until it uses the original source location to obtain symbol information for semantically-correct binding on paste), I don't think we can remove the option. |
this is a fair point - I hit this at least once since I wrote the original comment (mef types) |
…o poison * upstream/features/required-members: (413 commits) [EE] Implement IDkmClrFullNameProvider2 in Roslyn's ResultProvider Formatter. (dotnet#60522) Remove parameter null-checking from the Language Feature Status list (dotnet#61302) Add pointer for `AnalysisLevel` to warning waves doc (dotnet#61196) Add an UWP OptProf test for IDE Add test Fix issue where we were getting a raw-string in a skipped token, causing a crash Fix several LSP completion kind mappings (dotnet#61243) Relax assertion in SyntheticBoundNodeFactory.Convert (dotnet#61287) Enable add usings on paste by default (dotnet#61299) Fix focus on rename UI opening (dotnet#60846) Update PublishData.json with new package Remove Razor and editor inference document option providers (dotnet#61091) Fix nested in generic type binding issues in enabled nullability context (dotnet#61182) Revert "Revert "Improve editorconfig options caching on ProjectState (dotnet#61131)" (dotnet#61216)" (dotnet#61283) Move MSBuild back to 16.5.0. Fix a few build and package issues (dotnet#61273) lint Revert workspaces msbuild changes. Use SegmentedHashSet<T> to eliminate LOH allocations in AsyncBatchingWorkQueue NRT ...
With the new experience no longer blocking the UI thread, we want to enable this feature by default in 17.3