Remove deprecated NuPkg projects#60839
Conversation
These two NuGet projects were from the very early Roslyn days and are incomplete. The intent was to delete them long ago but we forgot to do so. The primary one maintained now for distributing the compiler (on a fast patch basis only) is Microsoft.Net.Compilers.Toolset
|
@dotnet/roslyn-infrastructure PTAL |
| <TargetFramework>net6.0</TargetFramework> | ||
|
|
||
| <IsPackable>true</IsPackable> | ||
| <NuspecPackageId>Microsoft.NETCore.Compilers</NuspecPackageId> |
There was a problem hiding this comment.
Couple of questions:
-
I'm not familiar with arcade and how it works, but I'm seeing the package name referenced in a comment here. Anything need to be updated somewhere to use the Microsoft.Net.Compilers.Toolset? Edit: Comment is only outdated. Opened Updated outdated comment arcade#9095
-
The package has recent releases on NuGet.org. Should it now be marked deprecated/obsolete?
-
Also https://github.com/dotnet/format/blob/68502482e34922e02108f6c1e7f7913bfecd1058/eng/Version.Details.xml#L4-L7 Edit: Tracked by Update
Microsoft.NETCore.CompilerstoMicrosoft.Net.Compilers.Toolsetformat#1580 -
The solution filter still references the deleted packages I think.
-
Also docs/wiki/Troubleshooting-tips.md mentions it
-
Also eng/config/PublishData.json
There was a problem hiding this comment.
I'm not familiar with arcade and how it works, but I'm seeing the package name referenced in a comment here.
The comment is out of date. The actual code that controls refers to the supported package.
The package has recent releases on NuGet.org. Should it now be marked deprecated/obsolete?
Yes once this is done I'm going to obsolete them. They've been previously listed as obsolete.
The solution filter still references the deleted packages I think.
Sigh, we really need to delete Compilers.sln or Compilers.slf. Having both is just annoying.
Also eng/config/PublishData.json
Can fix that up.
There was a problem hiding this comment.
Sigh, we really need to delete
Compilers.slnorCompilers.slf. Having both is just annoying.
There is #47531
|
/azp run roslyn-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Revert changes to PublishData.json from #60839
These two NuGet projects were from the very early Roslyn days and are
incomplete. The intent was to delete them long ago but we forgot to do
so. The primary one maintained now for distributing the compiler (on a
fast patch basis only) is Microsoft.Net.Compilers.Toolset