Use solution filter instead of multiple solutions#47531
Use solution filter instead of multiple solutions#47531sharwell wants to merge 2 commits intodotnet:mainfrom
Conversation
|
slnf doesn't seem to work with the version of dotnet build we use for CI |
|
That should get fixed when we move to a new .NET SDK version, believe @333fred already has a PR out to do just that. But we're blocked on a number of issues to get that in. 😦 |
333fred
left a comment
There was a problem hiding this comment.
Solution filters do not work with vscode.
Several other repositories in the organization have already switched to using solution filters. Can you be more specific? |
If they have, then they do not have users that work in vscode that regularly use the solutions they removed. It's certainly possible that we could add the feature to omnisharp, but today omnisharp does not support loading slnf files. |
| "src\\Compilers\\VisualBasic\\Test\\Symbol\\Microsoft.CodeAnalysis.VisualBasic.Symbol.UnitTests.vbproj", | ||
| "src\\Compilers\\VisualBasic\\Test\\Syntax\\Microsoft.CodeAnalysis.VisualBasic.Syntax.UnitTests.vbproj", | ||
| "src\\Compilers\\VisualBasic\\vbc\\vbc.csproj", | ||
| "src\\Dependencies\\CodeAnalysis.Debugging\\Microsoft.CodeAnalysis.Debugging.shproj", |
There was a problem hiding this comment.
This is another issue that affects Mac and Linux users that we need to take into account - dotnet/msbuild#5715
~/Source/roslyn [master ≡ +1 ~0 -0 !]> dotnet restore "./Compilers.slnf"
/Users/joeyrobichaud/Source/roslyn/src/Analyzers/CSharp/Analyzers/CSharpAnalyzers.shproj : Solution file error MSB5028: Solution filter file at "System.Collections.Generic.HashSet`1[System.String]" includes project "src\Analyzers\CSharp\Analyzers\CSharpAnalyzers.shproj" that is not in the solution file at "/Users/joeyrobichaud/Source/roslyn/Roslyn.sln".
|
@sharwell @333fred VSCode now supports slnf (OmniSharp/omnisharp-roslyn#2121). I think it should be possible to get this in? |
The following items were present in Compilers.slnf even though they were not present in Compilers.sln. I did not remove these items: