Merge main to features/required-members#60407
Merged
dotnet-bot merged 73 commits intofeatures/required-membersfrom Mar 27, 2022
Merged
Merge main to features/required-members#60407dotnet-bot merged 73 commits intofeatures/required-membersfrom
dotnet-bot merged 73 commits intofeatures/required-membersfrom
Conversation
Even if it might be stale. the completion list would be computed with cached data and cache refresh would be done in background.
Even if it might be stale. the completion list would be computed with cached data and cache refresh would be done in background.
…pletion is triggered
This can be used to tweak test behavior to make it deterministic
…ionOptions.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Follow up to #60165 We don't think this is the right default as users probably don't want this unless they have at least 8 cores.
Ban incompatible service provider extension methods
* Add support for CheckedStatement * Address feedback * Remove a not needed import
Fix issue when multiple different diagnostics share a single fixer
* Fix our x86 test execution The transition to `dotnet test` seems to have broken our unit tests that depend on executing on an x86 architecture. This fixes that by using the `--arch` argument to the `dotnet test` execution. This was made more general to facilitate our future arm64 work in this area * Disable test failing on x64 * fix the test * Apply suggestions from code review Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> * Disable test on spanish * Test fixes Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
This was being resized constantly after opening Orchard Core, allocating about 2 GB. The fact that is being called this many times appears to be another bug that I'm following up on.
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Create solution on the main thread in integration tests
…or-non-code-files
…way for visiting initializer (#60210)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from main into features/required-members.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout -t upstream/merges/main-to-features/required-members git reset --hard upstream/features/required-members git merge upstream/main # Fix merge conflicts git commit git push upstream merges/main-to-features/required-members --force