Create solution on the main thread in integration tests#60366
Merged
JoeRobich merged 3 commits intodotnet:mainfrom Mar 24, 2022
Merged
Create solution on the main thread in integration tests#60366JoeRobich merged 3 commits intodotnet:mainfrom
JoeRobich merged 3 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
approved these changes
Mar 24, 2022
allisonchou
approved these changes
Mar 24, 2022
jasonmalinowski
approved these changes
Mar 24, 2022
Comment on lines
+149
to
+153
| InvokeOnUIThread(cancellationToken => | ||
| { | ||
| ErrorHandler.ThrowOnFailure(solution.CreateSolution(solutionPath, solutionFileName, (uint)__VSCREATESOLUTIONFLAGS.CSF_SILENT)); | ||
| ErrorHandler.ThrowOnFailure(solution.SaveSolutionElement((uint)__VSSLNSAVEOPTIONS.SLNSAVEOPT_ForceSave, null, 0)); | ||
| }); |
Member
There was a problem hiding this comment.
Do we understand why this worked before?
Member
Author
There was a problem hiding this comment.
I do not. Where is the right place to start in investigating that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes from #58873
Also skip failing integration tests - #60364