Skip to content

Disable additional text comparer in generator driver#59776

Merged
RikkiGibson merged 1 commit intodotnet:mainfrom
chsienki:disable_additionaltext_comparer
Feb 25, 2022
Merged

Disable additional text comparer in generator driver#59776
RikkiGibson merged 1 commit intodotnet:mainfrom
chsienki:disable_additionaltext_comparer

Conversation

@chsienki
Copy link
Copy Markdown
Member

Disables the additional text comparer in the generator driver. This is only used when the experimental driver cache is enabled, and is causing issues with binary files. The actual fix is more involved, so rolling back for now.

Related #56249

@chsienki chsienki requested a review from a team as a code owner February 25, 2022 19:42
@RikkiGibson RikkiGibson enabled auto-merge (squash) February 25, 2022 22:27
@RikkiGibson RikkiGibson disabled auto-merge February 25, 2022 22:28
@RikkiGibson RikkiGibson merged commit 61b5ea1 into dotnet:main Feb 25, 2022
@ghost ghost added this to the Next milestone Feb 25, 2022
chsienki added a commit to chsienki/roslyn that referenced this pull request Feb 25, 2022
333fred added a commit that referenced this pull request Feb 28, 2022
…ures/required-members

* upstream/main: (187 commits)
  Add GlobalOptions.SetBackgroundAnalysisScope and PythiaGlobalOptions External Access API (#59794)
  Update source-build dependency to source-build-externals (#59549)
  Do not retry on Clipboard API for StackTraceExplorer (#59658)
  Remove unnecessary accesses on XML end tag (#59771)
  Threading
  lint
  Improve PDB source document project handling (#59643)
  Disable Auto-Open behavior for Stack Trace Explorer (#59785)
  REmove comment
  Push async up
  Simplify
  Remove stale remarks
  Update src/Tools/ExternalAccess/FSharp/Navigation/FSharpDocumentNavigationService.cs
  Remove unnecessary code
  Simplify threading
  Update tests
  Make the  IDocumentNavigationSerivice entirely async.
  Disable additional text comparer in generator driver (#59776)
  [LSP] Cache parsed xml snippets for razor (#59605)
  Make static
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants