[LSP] Cache parsed xml snippets for razor#59605
Merged
dibarbet merged 5 commits intodotnet:mainfrom Feb 25, 2022
Merged
Conversation
dibarbet
commented
Feb 17, 2022
| return parsedSnippet; | ||
| } | ||
|
|
||
| private static CodeSnippet RetrieveSnippetXmlFromFile(SnippetInfo snippetInfo) |
Member
Author
There was a problem hiding this comment.
| private static ParsedXmlSnippet GetAndParseSnippetFromFile(SnippetInfo snippetInfo) | ||
| { | ||
| // Read the XML file to get the snippet and snippet metadata. | ||
| var matchingSnippet = RetrieveSnippetXmlFromFile(snippetInfo); |
Member
Author
There was a problem hiding this comment.
davidwengier
approved these changes
Feb 17, 2022
src/Features/LanguageServer/Protocol/Handler/InlineCompletions/InlineCompletionsHandler.cs
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/InlineCompletions/XmlSnippetParser.cs
Outdated
Show resolved
Hide resolved
333fred
added a commit
that referenced
this pull request
Feb 28, 2022
…ures/required-members * upstream/main: (187 commits) Add GlobalOptions.SetBackgroundAnalysisScope and PythiaGlobalOptions External Access API (#59794) Update source-build dependency to source-build-externals (#59549) Do not retry on Clipboard API for StackTraceExplorer (#59658) Remove unnecessary accesses on XML end tag (#59771) Threading lint Improve PDB source document project handling (#59643) Disable Auto-Open behavior for Stack Trace Explorer (#59785) REmove comment Push async up Simplify Remove stale remarks Update src/Tools/ExternalAccess/FSharp/Navigation/FSharpDocumentNavigationService.cs Remove unnecessary code Simplify threading Update tests Make the IDocumentNavigationSerivice entirely async. Disable additional text comparer in generator driver (#59776) [LSP] Cache parsed xml snippets for razor (#59605) Make static ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup change to the original PR. We can easily cache the
SnippetParts we get from parsing the snippet XML so that we don't have to re-parse them from XML on each request.