Attempt to mark EqualityContract property accessor as not auto-implemented#57917
Merged
333fred merged 7 commits intodotnet:mainfrom Nov 30, 2021
Merged
Attempt to mark EqualityContract property accessor as not auto-implemented#57917333fred merged 7 commits intodotnet:mainfrom
333fred merged 7 commits intodotnet:mainfrom
Conversation
Youssef1313
commented
Nov 22, 2021
...ers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
AlekseyTs
reviewed
Nov 29, 2021
...ers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs
Show resolved
Hide resolved
Contributor
|
Done with review pass (commit 2) |
Youssef1313
commented
Nov 30, 2021
AlekseyTs
reviewed
Nov 30, 2021
...ers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs
Show resolved
Hide resolved
AlekseyTs
reviewed
Nov 30, 2021
Contributor
|
Done with review pass (commit 5). |
AlekseyTs
approved these changes
Nov 30, 2021
Contributor
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (commit 7), assuming CI is passing.
Contributor
|
@dotnet/roslyn-compiler For a second review. |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Dec 3, 2021
…rovements * upstream/main: (310 commits) Read SourceLink info and call service to retrieve source from there (dotnet#57978) Add new parser/lexer to the StackTraceAnalyzer (dotnet#57598) (dotnet#58050) Snap 17.1 P2 (dotnet#58041) Make it possible to analyze the dataflow of `ConstructorInitializerSyntax` and `PrimaryConstructorBaseTypeSyntax` (dotnet#57576) Shorten paths in VS installation (dotnet#57726) Add comments Add new parser/lexer to the StackTraceAnalyzer (dotnet#57598) Fix await completion for expression body lambda Add tests Fix comment Honor option, and also improve formatting with comment Skip TestLargeStringConcatenation (dotnet#58035) Log runtime framework of remote host Mark EqualityContract property accessor as not auto-implemented (dotnet#57917) Fix typo in XML doc for GeneratorExtensions (dotnet#58020) Hold Receiver directly in bound node for implicit indexer access (dotnet#58009) Pass AnalysisKind instead of int Enable nullable reference types for TableDataSource Simplify 'interpolation' data, and move to an easier to consume System.Range approach for it (dotnet#57966) Add missing test for CallerArgumentExpression (dotnet#57805) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No idea if this will fail something. But at a first glance it looks like it shouldn't be an auto implemented property accessor. The property itself isn't auto property, why would the accessor be?
The motivation for the change here is to make
isAutoPropertyAccessoralways matchingproperty.IsAutoPropertyso we can actually be able to remove the parameter entirely.This is one step towards making #57915 pass, which will make the life much easier for semi auto props.
@AlekseyTs for review.