Shorten paths in VS installation#57726
Conversation
|
VS build to validate: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/364093 |
|
|
||
| <CommonExtensionInstallationRoot>CommonExtensions</CommonExtensionInstallationRoot> | ||
| <LanguageServicesExtensionInstallationFolder>Microsoft\ManagedLanguages\VBCSharp\LanguageServices</LanguageServicesExtensionInstallationFolder> | ||
| <LanguageServicesExtensionInstallationFolder>Microsoft\VBCSharp\LanguageServices</LanguageServicesExtensionInstallationFolder> |
There was a problem hiding this comment.
i'm curious why we don't just reduce this to Microsoft\VBCSharp. Is the LanguageServices part helpful?
There was a problem hiding this comment.
Both LanguageServices and ExpressionEvaluator are extensions that have been extracted, so they have a few overlapping files, like manifest.json etc.
I did propose on an email thread shortening them to LS and EE, or we could do VBCSLanguageServices and VBCSExpressionEvaluator directly under the Microsoft folder. To be perfectly frank the "Microsoft" bit seems a little redundant even :)
|
@davidwengier Could you please validate our .Net 6 OOP still work with this change? Especially our dependent services (Test discovery, razor, etc.), which used to use relative path to Roslyn for assembly probing. It was removed a while ago, so our OOP services shouldn't be affected. But just in case :) |
jasonmalinowski
left a comment
There was a problem hiding this comment.
I can't wait to see what components have improperly taken dependencies on this!
|
|
|
This gets me wondering if win11 is changing any defaults around long paths. |
|
Update: The razor issue is https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1433840 so going to rebase the VS branch and try again. |
|
Razor works! 🎉 As does LUT, test discovery, with .NET 6 host and non. Seems normal to me :) |
|
@davidwengier Thanks for the validation! |
|
This has passed manual testing :D |
|
FYI @y87feng, who's fixing a similar issue and could make the same change for LUT and SBD. |
|
Changed to release/dev17.1. @jinujoseph for M2 |
…rovements * upstream/main: (310 commits) Read SourceLink info and call service to retrieve source from there (dotnet#57978) Add new parser/lexer to the StackTraceAnalyzer (dotnet#57598) (dotnet#58050) Snap 17.1 P2 (dotnet#58041) Make it possible to analyze the dataflow of `ConstructorInitializerSyntax` and `PrimaryConstructorBaseTypeSyntax` (dotnet#57576) Shorten paths in VS installation (dotnet#57726) Add comments Add new parser/lexer to the StackTraceAnalyzer (dotnet#57598) Fix await completion for expression body lambda Add tests Fix comment Honor option, and also improve formatting with comment Skip TestLargeStringConcatenation (dotnet#58035) Log runtime framework of remote host Mark EqualityContract property accessor as not auto-implemented (dotnet#57917) Fix typo in XML doc for GeneratorExtensions (dotnet#58020) Hold Receiver directly in bound node for implicit indexer access (dotnet#58009) Pass AnalysisKind instead of int Enable nullable reference types for TableDataSource Simplify 'interpolation' data, and move to an easier to consume System.Range approach for it (dotnet#57966) Add missing test for CallerArgumentExpression (dotnet#57805) ...
Contributes to AB#1433021 but the final fix will be in the VS insertion
Will do a val build and insert it into https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/364093 for testing