Add feature to simplify code to use the new extended property patterns when available.#55704
Conversation
…803.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21403.5
…806.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21406.6
…810.8 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21410.8
…812.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21412.1
Only analyzers that use SolutionCrawlerOptions internally need to reanalyze when these options change. The tests are now updated to reflect this change.
…akhera99/roslyn into add_indexer_option_inline_hints
…813.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21413.4
🐇 Store weak references in s_structuresTable
…oslyn into dev/jorobich/update-sdk
…simplePropertyPattern
…build-pool Allow the integration CI pipeline to specify a build pool
333fred
left a comment
There was a problem hiding this comment.
Looks like there's a merge of commits that aren't yet in main, will hold off approving until those commits are merged and this PR shows a clean diff.
Update Arcade and require .NET 6 Preview 7 SDK
🐛 Implement PackageSettingsPersister.TryFetch
…dotnet#55713) Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
|
@CyrusNajmabadi it doesn't look like there was 2 compiler reviews. I was holding off on approving this until I could actually review a clean diff with the target branch, which is now impossible. |
|
This shouldnt' have needed 2 compiler reviews afaict. All i did was merge main into this branch. Do you review those changes? |
|
Any non-test changes that touch the compiler folder need 2 reviews. I cannot separate your changes from the merge, so no I was not able to review them. |
|
Moreover, because this pr was merged bringing in a whole bunch of unrelated commits, it means we can't easily revert the changes if necessary. In the future, please do not merge a pr with unrelated commits in the merge because codeflow has not yet occurred. |
|
Ok, i won't do in the future. This was done here though to unblock CI, which needed those changes to properly use sdk-preview7 and which had already been approved in #55681. It pulled in 'main'. But 'main' is already something we auto-approve for merge into later-release branches. Given the contents were all approved already, i didn't know there needed to be additional approval. But in the future i can avoid this if it is problematic. |
Right, I understand this. However, |
Looks like this:
Todo:
Fixes #55545
Relates to test plan #52468