Update Arcade and require .NET 6 Preview 7 SDK by JoeRobich · Pull Request #55681 · dotnet/roslyn

JoeRobich · 2021-08-17T21:47:42Z

Arcade is currently pushing early builds of .NET 6 RC which would be difficult to require contributors to install in order to develop against Roslyn. This moves us to the latest published Preview version and brings in recent Arcacde changes.

…803.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21403.5

…806.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21406.6

…810.8 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21410.8

…812.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21412.1

…813.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21413.4

RikkiGibson · 2021-08-17T23:40:17Z

Do we know why they are pushing such new versions of the SDK?

JoeRobich · 2021-08-18T00:08:41Z

Do we know why they are pushing such new versions of the SDK?

I have not asked. I assumed it was to get RC as much validation as possible before it gets released.

dibarbet · 2021-08-18T17:40:52Z

/azp run

azure-pipelines · 2021-08-18T17:41:19Z

Azure Pipelines successfully started running 3 pipeline(s).

jkoritzinsky · 2021-08-18T22:58:01Z

Arcade moved to the RC1 SDK to help alleviate NuGet feed instability that dotnet/aspnetcore and dotnet/runtime were hitting at extremely high frequency.

…oslyn into dev/jorobich/update-sdk

dibarbet · 2021-08-19T03:33:24Z

The test CsiScript_WithSourceCodeRedirectedViaStandardInput_ExecutesNonInteractively is failing when targeting net5.0 (but not when targeting net472).

Compilation error(s) occurred:  System.TypeLoadException: Could not load type 'System.Int32' from assembly 'R*ad9ddb7c-7900-42d3-b5d7-ff74566f9be0#1-0, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' due to value type mismatch.
  + System.Delegate.BindToMethodInfo(object, System.IRuntimeMethodInfo, System.RuntimeType, System.DelegateBindingFlags)
  + System.Reflection.RuntimeMethodInfo.CreateDelegateInternal(System.Type, object, System.DelegateBindingFlags)
  + System.Reflection.RuntimeMethodInfo.CreateDelegate(System.Type)
  + Roslyn.Utilities.ReflectionUtilities.CreateDelegate<T>(System.Reflection.MethodInfo) at C:\Users\dabarbet\source\repos\roslyn\src\Compilers\Core\Portable\InternalUtilities\ReflectionUtilities.cs : 115
  + Microsoft.CodeAnalysis.Scripting.ScriptBuilder.Build<T>(Microsoft.CodeAnalysis.Compilation, Microsoft.CodeAnalysis.DiagnosticBag, bool, System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\ScriptBuilder.cs : 166
  + Microsoft.CodeAnalysis.Scripting.ScriptBuilder.CreateExecutor<T>(Microsoft.CodeAnalysis.Scripting.ScriptCompiler, Microsoft.CodeAnalysis.Compilation, bool, System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\ScriptBuilder.cs : 88
  + Script<T>.GetExecutor(System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\Script.cs : 365
  + Script<T>.RunAsync(object, Func<System.Exception, bool>, System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\Script.cs : 469
  + Script<T>.RunAsync(object, System.Threading.CancellationToken) at C:\Users\dabarbet\source\repos\roslyn\src\Scripting\Core\Script.cs : 443

Expected: False
Actual:   True

@dotnet/roslyn-compiler could I get some assistance tracking down this issue? It is easy to repro locally by just checking out this branch. I haven't found anything obvious after a cursory investigation, but I'm very unfamiliar with this bit. Feel free to push to the branch. If the test failure is not important, let me know and I can disable it.

Format.cmd

dotnet-tools.json

eng/format.ps1

eng/format.sh

format.sh

src/CodeStyle/VisualBasic/CodeFixes/Microsoft.CodeAnalysis.VisualBasic.CodeStyle.Fixes.vbproj

src/CodeStyle/VisualBasic/Tests/Microsoft.CodeAnalysis.VisualBasic.CodeStyle.UnitTests.vbproj

src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpWinForms.cs

src/VisualStudio/IntegrationTest/TestUtilities/WellKnownProjectTemplates.cs

…oslyn into dev/jorobich/update-sdk

JoeRobich · 2021-08-19T23:18:45Z

The Linux_Single machine tests have passed. Merging this in since we haven't seen issues in the MacOS leg during previous runs and this unblocks CI.

Update Arcade and require .NET 6 Preview 7 SDK

dotnet-maestro bot and others added 7 commits August 5, 2021 12:14

Update dependencies from https://github.com/dotnet/arcade build 20210…

acb8afb

…803.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21403.5

Update dependencies from https://github.com/dotnet/arcade build 20210…

39e42e7

…806.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21406.6

Reverted SDK version change

a963a0f

Update dependencies from https://github.com/dotnet/arcade build 20210…

1cedbb9

…810.8 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21410.8

Update dependencies from https://github.com/dotnet/arcade build 20210…

a3eddbd

…812.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21412.1

Update dependencies from https://github.com/dotnet/arcade build 20210…

4174b3a

…813.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21379.2 -> To Version 6.0.0-beta.21413.4

Update to .NET 6 Preview 7 SDK

b9443e9

JoeRobich requested a review from a team as a code owner August 17, 2021 21:47

ghost added the Area-Infrastructure label Aug 17, 2021

JoeRobich mentioned this pull request Aug 17, 2021

[Complete] Require .NET 6 Preview 7 SDK for Roslyn development #55680

Closed

Add additional imports

96673ef

JoeRobich requested review from a team as code owners August 17, 2021 23:06

ryzngard approved these changes Aug 17, 2021

View reviewed changes

Merge branch 'main' into dev/jorobich/update-sdk

32bf2c8

vzarytovskii mentioned this pull request Aug 17, 2021

Can't build main? Do a complete clean - also Can't build main in VS 2019 dotnet/fsharp#11986

Closed

JoeRobich added 3 commits August 18, 2021 11:53

Update RoslynTools.VSIXExpInstaller version to 1.1.0-beta3.21418.3

d760e4d

Update dotnet-format invocation in build correctness test

86bba26

Restore dotnet-format local tool and add helper scripts

45f01f2

jmarolf approved these changes Aug 18, 2021

View reviewed changes

dibarbet added 3 commits August 18, 2021 16:15

Modify integration tests in response to template changes in dev17p3

95d32ef

Also skip rename due to bug

7e13760

Merge branch 'dev/jorobich/update-sdk' of https://github.com/dotnet/r…

373b060

…oslyn into dev/jorobich/update-sdk

This was referenced Aug 19, 2021

Internal modifier added to partial classes breaks new project creation for WinForms, WebTools and anything using partial classes in their templates #55703

Closed

Re-enable MetadataReference integration test #55711

Closed

additional fixes

44840d6

Verify different squiggles on .net framework

17683dc

dibarbet force-pushed the dev/jorobich/update-sdk branch from 163cb5a to 17683dc Compare August 19, 2021 04:24

sharwell suggested changes Aug 19, 2021

View reviewed changes

JoeRobich and others added 4 commits August 19, 2021 09:45

Remove format scripts

1741ddd

Restore final newline to dotnet-tools.json

39ef865

review feedback

7372a2e

Merge branch 'dev/jorobich/update-sdk' of https://github.com/dotnet/r…

db1806d

…oslyn into dev/jorobich/update-sdk

jcouv mentioned this pull request Aug 19, 2021

Disallow nullable suppression in patterns #54072

Merged

dibarbet mentioned this pull request Aug 19, 2021

Re-enable CsiScript_WithSourceCodeRedirectedViaStandardInput_ExecutesNonInteractively #55727

Open

Skip failing compilers test

2ffe852

sharwell approved these changes Aug 19, 2021

View reviewed changes

dibarbet mentioned this pull request Aug 19, 2021

Re-enable test CommandLineTests.ReservedDeviceNameAsFileName #55730

Closed

Skip additional test that is causing CI timeouts

f14601e

JoeRobich merged commit 398d7b6 into main Aug 19, 2021

ghost added this to the Next milestone Aug 19, 2021

RikkiGibson deleted the dev/jorobich/update-sdk branch August 19, 2021 23:30

CyrusNajmabadi mentioned this pull request Aug 20, 2021

Add feature to simplify code to use the new extended property patterns when available. #55704

Merged

1 task

allisonchou pushed a commit to allisonchou/roslyn that referenced this pull request Aug 20, 2021

Merge pull request dotnet#55681 from dotnet/dev/jorobich/update-sdk

6e681eb

Update Arcade and require .NET 6 Preview 7 SDK

dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021

jmarolf mentioned this pull request Feb 7, 2022

Add repo files to Roslyn.sln and Compilers.sln as solution items #59328

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Arcade and require .NET 6 Preview 7 SDK#55681

Update Arcade and require .NET 6 Preview 7 SDK#55681
JoeRobich merged 23 commits intomainfrom
dev/jorobich/update-sdk

JoeRobich commented Aug 17, 2021

Uh oh!

RikkiGibson commented Aug 17, 2021

Uh oh!

JoeRobich commented Aug 18, 2021

Uh oh!

dibarbet commented Aug 18, 2021

Uh oh!

azure-pipelines bot commented Aug 18, 2021

Uh oh!

jkoritzinsky commented Aug 18, 2021

Uh oh!

dibarbet commented Aug 19, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoeRobich commented Aug 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

JoeRobich commented Aug 17, 2021

Uh oh!

RikkiGibson commented Aug 17, 2021

Uh oh!

JoeRobich commented Aug 18, 2021

Uh oh!

dibarbet commented Aug 18, 2021

Uh oh!

azure-pipelines bot commented Aug 18, 2021

Uh oh!

jkoritzinsky commented Aug 18, 2021

Uh oh!

dibarbet commented Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoeRobich commented Aug 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dibarbet commented Aug 19, 2021 •

edited

Loading