Don't add accessibility modifiers to partial classes in new documents#55713
Merged
davidwengier merged 5 commits intodotnet:mainfrom Aug 20, 2021
Merged
Conversation
…sing new documents
sharwell
approved these changes
Aug 19, 2021
src/Analyzers/CSharp/Tests/AddAccessibilityModifiers/AddAccessibilityModifiersTests.cs
Show resolved
Hide resolved
...ures/CSharp/Portable/Formatting/CSharpAccessibilityModifiersNewDocumentFormattingProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Aug 19, 2021
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
c# side lgtm. but can we validate if we have an issue with VB?
Member
Author
Mentioned above, but for visibility, adjusting accessibility modifiers in new documents only happens for C# files. |
PackageSettingsPersister.InitializeAsync is not guaranteed to complete before the constructor returns, so it's possible for TryFetch to be called. This method is now implemented to provide a best-known value prior to initialization completing.
…ersForPartialModifiers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55703
Unfortunately we don't have enough information to go on when processing new documents to do anything smarter here :(