Skip to content

Revert "Switch to full ngen for Roslyn binaries"#53952

Merged
genlu merged 1 commit intorelease/dev17.0-preview1-vs-depsfrom
revert-53837-fullNgen
Jun 9, 2021
Merged

Revert "Switch to full ngen for Roslyn binaries"#53952
genlu merged 1 commit intorelease/dev17.0-preview1-vs-depsfrom
revert-53837-fullNgen

Conversation

@genlu
Copy link
Copy Markdown
Member

@genlu genlu commented Jun 8, 2021

Reverts #53837

There's unexplained/unexpected impact of opting out of partial-ngen on perf test reliability, so we will fold off this change until VSEng figure out the root cause.

@genlu genlu requested a review from a team June 8, 2021 19:27
@genlu genlu requested review from a team as code owners June 8, 2021 19:27
@genlu genlu requested a review from a team June 8, 2021 19:27
@ghost ghost added the Area-Infrastructure label Jun 8, 2021
@genlu
Copy link
Copy Markdown
Member Author

genlu commented Jun 9, 2021

We didn't insert the full ngen change into preview1, so we don't need to insert this either. This is just to ensure we don't do full ngen in preview2.

@genlu genlu merged commit 5536669 into release/dev17.0-preview1-vs-deps Jun 9, 2021
@genlu genlu deleted the revert-53837-fullNgen branch June 9, 2021 17:27
genlu added a commit to genlu/roslyn that referenced this pull request Jul 20, 2021
…Ngen"

This reverts commit 5536669, reversing
changes made to b6a9f8c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants