Skip to content

Switch to full ngen for Roslyn binaries#53837

Merged
genlu merged 1 commit intodotnet:release/dev17.0-preview1-vs-depsfrom
genlu:fullNgen
Jun 2, 2021
Merged

Switch to full ngen for Roslyn binaries#53837
genlu merged 1 commit intodotnet:release/dev17.0-preview1-vs-depsfrom
genlu:fullNgen

Conversation

@genlu
Copy link
Copy Markdown
Member

@genlu genlu commented Jun 2, 2021

@genlu genlu requested review from a team and tmat June 2, 2021 19:13
@genlu genlu requested review from a team as code owners June 2, 2021 19:13
@genlu genlu requested a review from a team June 2, 2021 19:13
@ghost ghost added the Area-Infrastructure label Jun 2, 2021
@genlu genlu enabled auto-merge June 2, 2021 19:24
Copy link
Copy Markdown
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot wait to not have to worry about optprof data 😆

@tmat
Copy link
Copy Markdown
Member

tmat commented Jun 2, 2021

@333fred I think we would still care - the full NGEN uses optprof data to decide how to lay out the generated code.

@333fred
Copy link
Copy Markdown
Member

333fred commented Jun 2, 2021

@333fred I think we would still care - the full NGEN uses optprof data to decide how to lay out the generated code.

Well now I am sad again.

@genlu
Copy link
Copy Markdown
Member Author

genlu commented Jun 2, 2021

@333fred Hey, at least we won't see as many image size regressions :)

@genlu genlu disabled auto-merge June 2, 2021 20:24
@genlu genlu merged commit 5dc3c06 into dotnet:release/dev17.0-preview1-vs-deps Jun 2, 2021
@genlu genlu deleted the fullNgen branch June 2, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants