Merged
Conversation
tmat
commented
Jun 9, 2021
tmat
commented
Jun 9, 2021
tmat
commented
Jun 9, 2021
tmat
commented
Jun 9, 2021
src/Features/Core/Portable/EditAndContinue/Remote/ActiveStatementSpanProviderCallback.cs
Outdated
Show resolved
Hide resolved
tmat
commented
Jun 9, 2021
src/Workspaces/Core/Portable/Shared/Extensions/IEnumerableExtensions.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@davidwengier PTAL |
Member
|
So is the behaviour for multiple sessions so?:
After 3, if A emits updates, it receives all the changes P and Q in the deltas provided by the EnC service. |
Member
Author
|
StartSession and EmitSolutionUpdate take Solution snapshot as a parameter. EmitSolutionUpdate returns the diff between last Solution snapshot (either passed to StartSession or previous EmitSolutionUpdate) and the current one. |
src/Features/Core/Portable/ExternalAccess/Watch/Api/WatchHotReloadService.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/ExternalAccess/UnitTesting/API/UnitTestingHotReloadService.cs
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/ListExtensions.cs
Show resolved
Hide resolved
Member
|
The compiler changes look fine to me, but there was no sign off for them. Perhaps we need to adjust our process to ensure the compiler team reviews these PRs in a timely manner. |
Member
Author
|
Thanks for review. I forgot these files are shared with the compiler. |
333fred
added a commit
that referenced
this pull request
Jun 14, 2021
…ures/interpolated-string * upstream/main: (95 commits) Update official build number in separate job Update Language Feature Status.md (#54015) Remove IRazorDocumentOptionsService inheritance interface (#54047) Fix comment Simplify Do not create a cache field for lambda if it depends on caller's type argument (#44939) Documentation Documentation Documentation Update test impls Just pass null Pull diagnostics should just request from the doc, not the whole project. Add test plan for file-scoped namespace (#54003) Add source build to official build Improved nullable 'is' analysis (#53311) Multi session service (#53762) Resolve Versions.props conflicts Revert "Revert "Require partial method signatures to match" (47576) (#47879)" (#53352) Broaden enforcement on prototype marker (#53886) Update Language Feature Status.md (#53926) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors EditAndContinueWorkspaceService, DebuggingSession and EditSession to allow for multiple active DebuggingSessions at the same time. The currently active sessions are tracked by EditAndContinueWorkspaceService.
Adds UnitTestingHotReloadService to ExternalAccess. This service currently only allows a single Unit Testing hot reload session to be active at any time, but it's easy to change to keep track of multiple sessions.
Implements #53701