Revert "Require partial method signatures to match" (47576)#47879
Revert "Require partial method signatures to match" (47576)#47879cston merged 1 commit intodotnet:masterfrom
Conversation
| ERR_StaticAnonymousFunctionCannotCaptureThis = 8821, | ||
| ERR_OverrideDefaultConstraintNotSatisfied = 8822, | ||
| ERR_DefaultConstraintOverrideOnly = 8823, | ||
| WRN_PartialMethodTypeDifference = 8824, |
There was a problem hiding this comment.
I think you mark these with // Available comments?
There was a problem hiding this comment.
Yes, we could. But this PR simply reverts a previous change so I'll leave as is.
|
Any reason not to simply change the wave to 6 in this PR? Would it be riskier to do so? |
|
I just thought if there were a way to keep this functionality behind a flag that .NET 5 users won't encounter, it might make life slightly easier in 16.9, w.r.t. conflicts over error IDs and so on. |
I think this doesn't guarantee that users won't encounter this warning. For example, if they have |
Maybe skip the tests add |
It should be easy enough to re-revert this change in 16.9. There will need to be some changes (such as changing the warning wave used in tests), but it shouldn't be difficult. Let's just revert the original change now. |
…otnet#47879)" This reverts commit c785833.
…ures/interpolated-string * upstream/main: (95 commits) Update official build number in separate job Update Language Feature Status.md (#54015) Remove IRazorDocumentOptionsService inheritance interface (#54047) Fix comment Simplify Do not create a cache field for lambda if it depends on caller's type argument (#44939) Documentation Documentation Documentation Update test impls Just pass null Pull diagnostics should just request from the doc, not the whole project. Add test plan for file-scoped namespace (#54003) Add source build to official build Improved nullable 'is' analysis (#53311) Multi session service (#53762) Resolve Versions.props conflicts Revert "Revert "Require partial method signatures to match" (47576) (#47879)" (#53352) Broaden enforcement on prototype marker (#53886) Update Language Feature Status.md (#53926) ...
Reverting #47576. Moving the new warning to the 16.9 warning wave.