Merge main to features/improved-definite-assignment#53284
Merged
393 commits merged intofeatures/improved-definite-assignmentfrom May 9, 2021
Merged
Conversation
…429.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 6.0.0-beta.21167.3 -> To Version 6.0.0-beta.21229.1
Fixes #51521 Adds a new option to enable logging diagnostics information to a log file inside the temp folder, which the user can submit for any intellisense diagnostics/error list related issues. We are not investing in a full-fledged system here as we anticipate many architectural changes in the diagnostics system in Dev17. The support added here is a short term solution to enable getting additional logs.
…CodeRefactoringVerifier`1+Test.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
…CodeRefactoringVerifier`1+Test.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
IDE shoudl not attempt to replicate the compiler to generate diagnostics inside lambdas for constructors.
Switch pattern matching to use TemporaryArray
Combine duplicate private methods by one method having base class as parameter
Remove EnC completion flag
Merge features/source-build to main
Add records to C# declaration comparer
Fix spans for cached items at the manager level, not the service level
…-to-nullable-parameters Don't suggest to add null checks to nullable reference types
Add additional info to contract call
Merge release/dev16.11 to main
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from main into features/improved-definite-assignment.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout merges/main-to-features/improved-definite-assignment git reset --hard upstream/features/improved-definite-assignment git merge upstream/main # Fix merge conflicts git commit git push upstream merges/main-to-features/improved-definite-assignment --force