Fix spans for cached items at the manager level, not the service level#53261
Merged
CyrusNajmabadi merged 8 commits intodotnet:mainfrom May 7, 2021
Merged
Fix spans for cached items at the manager level, not the service level#53261CyrusNajmabadi merged 8 commits intodotnet:mainfrom
CyrusNajmabadi merged 8 commits intodotnet:mainfrom
Conversation
333fred
reviewed
May 7, 2021
CyrusNajmabadi
commented
May 7, 2021
src/Tools/ExternalAccess/OmniSharp/Completion/OmniSharpCompletionService.cs
Outdated
Show resolved
Hide resolved
Member
|
@CyrusNajmabadi sorry to disable auto-merge, but can you please take this for 16.11 or 16.10 instead? |
Contributor
Author
|
Still auto-merging. We can make anotehr PR to backport :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #53259