Add records to C# declaration comparer#48415
Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom May 7, 2021
Merged
Conversation
Member
Author
|
@CyrusNajmabadi Can you take a look? Thanks. |
Contributor
Yes. The affected code fixes should get tests here. Thanks! |
CyrusNajmabadi
approved these changes
May 7, 2021
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This affects some code fixes that generate code inside records.
As examples only:
See the failures in #48292
I'm not sure if the tests should go into any of those affected codefixes? or is there a more general tests specific to the declaration comparer?