Merge inheritance margin feature#52357
Merged
Cosifne merged 86 commits intorelease/dev16.10-vs-depsfrom Apr 3, 2021
Merged
Conversation
…nceMargin Merge release/dev16.10 to inheritance margin
Member
Author
|
This includes the inheritance margin feature and needs M2 approval. |
Member
Author
|
@sharwell @CyrusNajmabadi @ryzngard |
Contributor
|
I retargeted to vs-deps due to dependency changes. |
sharwell
reviewed
Apr 2, 2021
src/EditorFeatures/CSharp/InheritanceMargin/CSharpInheritanceMarginService.cs
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/InheritanceMargin/MarginGlyph/InheritanceMarginViewModel.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/InheritanceMargin/InheritanceGlyphFactoryProvider.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/InheritanceMargin/MarginGlyph/InheritanceMargin.xaml.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/InheritanceMargin/MarginGlyph/InheritanceMarginViewModel.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/Microsoft.CodeAnalysis.EditorFeatures.Wpf.csproj
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core/FindUsages/IDefinitionsAndReferencesFactory.cs
Outdated
Show resolved
Hide resolved
| threadingContext, solution.Workspace, title, definitions, cancellationToken)); | ||
| } | ||
|
|
||
| public static bool TryGoToDefinition( |
Contributor
There was a problem hiding this comment.
💡 After this merges, can remove the previous TryGoToDefinition method as a separate follow-up. You have the option of either filing a follow-up issue or submitting a PR to just remove it in favor of the new method.
Contributor
|
@allisonchou headsup for 16.10.P2 |
Merge 16.10-vs-deps to features/inheritanceMargin
Member
Author
|
This PR should be ready after #52379 is checked in, so plz dont' merge now |
sharwell
approved these changes
Apr 2, 2021
…anup Comments clean up for inheritance margin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.