Comments clean up for inheritance margin#52379
Merged
Cosifne merged 11 commits intodotnet:features/inheritanceMarginfrom Apr 3, 2021
Merged
Comments clean up for inheritance margin#52379Cosifne merged 11 commits intodotnet:features/inheritanceMarginfrom
Cosifne merged 11 commits intodotnet:features/inheritanceMarginfrom
Conversation
Cosifne
commented
Apr 2, 2021
| if (member.IsKind( | ||
| SyntaxKind.MethodDeclaration, | ||
| SyntaxKind.PropertyDeclaration, | ||
| SyntaxKind.EventDeclaration)) |
Cosifne
commented
Apr 2, 2021
| </data> | ||
| <data name="Multiple_members_are_inherited_on_line_0" xml:space="preserve"> | ||
| <value>Multiple members are inherited on line {0}</value> | ||
| <comment>Line number info is needed for accessibility purpose.</comment> |
Cosifne
commented
Apr 2, 2021
| _threadingContext, | ||
| _streamingFindUsagesPresenter, | ||
| _classificationTypeMap, | ||
| _classificationFormatMapService.GetClassificationFormatMap("tooltip"), |
Cosifne
commented
Apr 2, 2021
| var inlines = member.DisplayTexts.ToInlines(classificationFormatMap, classificationTypeMap); | ||
| WrapMemberWithinApostrophe(inlines); | ||
| inlines.Add(new Run(textAppended)); | ||
| var startOfThePlaceholder = ServicesVSResources._0_is_inherited.IndexOf("{0}", StringComparison.Ordinal); |
Cosifne
commented
Apr 2, 2021
| { | ||
| SetResourceReference(BackgroundProperty, "VsBrush.CommandBarMenuBackgroundGradient"); | ||
| SetResourceReference(BorderBrushProperty, "VsBrush.CommandBarMenuBorder"); | ||
| SetResourceReference(BackgroundProperty, VsBrushes.CommandBarMenuBackgroundGradientKey); |
Cosifne
commented
Apr 2, 2021
| <PackageReference Include="Microsoft.VisualStudio.Text.UI.Wpf" Version="$(MicrosoftVisualStudioTextUIWpfVersion)" /> | ||
| <PackageReference Include="Microsoft.VisualStudio.SDK.EmbedInteropTypes" Version="$(MicrosoftVisualStudioSDKEmbedInteropTypesVersion)" /> | ||
| <PackageReference Include="Microsoft.VisualStudio.Threading" Version="$(MicrosoftVisualStudioThreadingVersion)" /> | ||
| <PackageReference Include="Microsoft.VisualStudio.Shell.15.0" Version="$(MicrosoftVisualStudioShell150Version)" /> |
Member
Author
There was a problem hiding this comment.
Original comment:
#52357 (comment)
I have move the whole UI part to Microsoft.VisualStudio.LanguageServices project
Cosifne
commented
Apr 2, 2021
| return ToDefinitionItemAsync( | ||
| definition, solution, isPrimary: false, includeHiddenLocations, includeClassifiedSpans: false, | ||
| options: FindReferencesSearchOptions.Default, cancellationToken: cancellationToken); | ||
| options: FindReferencesSearchOptions.Default.With(unidirectionalHierarchyCascade: true), cancellationToken: cancellationToken); |
src/EditorFeatures/CSharp/InheritanceMargin/CSharpInheritanceMarginService.cs
Show resolved
Hide resolved
sharwell
approved these changes
Apr 2, 2021
...alStudio/Core/Def/Implementation/InheritanceMargin/MarginGlyph/InheritanceMarginViewModel.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits name indicates all the code change