Skip to content

Remove an unnecessary override.#52140

Merged
AlekseyTs merged 2 commits intomainfrom
AlekseyTs-patch-1
Mar 25, 2021
Merged

Remove an unnecessary override.#52140
AlekseyTs merged 2 commits intomainfrom
AlekseyTs-patch-1

Conversation

@AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested a review from a team as a code owner March 25, 2021 14:44
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review a small change

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review a small change, need a second sign-off.

@AlekseyTs AlekseyTs merged commit 9348117 into main Mar 25, 2021
@ghost ghost added this to the Next milestone Mar 25, 2021
@333fred 333fred mentioned this pull request Mar 25, 2021
333fred added a commit to 333fred/roslyn that referenced this pull request Mar 25, 2021
* upstream/main: (75 commits)
  Split BoundInterpolatedString into BoundInterpolatedString and BoundUnconvertedInterpolatedString (dotnet#52061)
  Combine VB comparers into one, and combine VB and C# comparers together (dotnet#51834)
  Use OptimizedVSCompletionList in LSP scenarios.
  F5 Hot Reload (dotnet#52101)
  Fix typescript shim
  Add tests for lazy syntax trees coming from the GeneratorDriver
  React to code review feedback.
  Simplify the lazy-initalization pattern used in GetRoot
  Remove an unnecessary override. (dotnet#52140)
  Update issue number (dotnet#52130)
  Enable CodeActions support for XAML using its own provider and CodeActionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129)
  Add RestrictedIVT to dotnet watch to Features (dotnet#52087)
  Don't try to highlight operators (dotnet#52041)
  Use `null` instead of empty signature helps in LSP
  Use member type for relational pattern even in error cases (dotnet#51950)
  Update src/VisualStudio/Xaml/Impl/Implementation/LanguageServer/Extensions/SymbolExtensions.cs
  Use new QuickInfoUtilities helper
  Rebuild API shape (dotnet#52079)
  Added position parameter name
  Updated XAML QuickInfo to show more info like C# by using ISymbolDisplayService and adding more documentation parts.
  ...
@AlekseyTs AlekseyTs deleted the AlekseyTs-patch-1 branch March 26, 2021 17:16
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants