Add RestrictedIVT to dotnet watch to Features#52087
Conversation
|
@davidwengier PTAL |
There was a problem hiding this comment.
Restricted IVTs are not needed for dotnet-watch, since a proper External Access assembly is available.
https://github.com/dotnet/roslyn/tree/main-vs-deps/src/Tools/ExternalAccess/DotNetWatch
|
It is needed since the External Access project can't access debugger internals. The debugger only has IVT to Features currently and I would rather not add more IVTs to the debugger. I'm going to remove the External Access project in future, once ASP.NET switches to the new API. |
We already updated that project to provide the new IVTs right? |
External Access seems significantly preferable as a maintainable solution, but RIVT still provides some of the benefits
Not sure what do you mean. |
* upstream/main: (75 commits) Split BoundInterpolatedString into BoundInterpolatedString and BoundUnconvertedInterpolatedString (dotnet#52061) Combine VB comparers into one, and combine VB and C# comparers together (dotnet#51834) Use OptimizedVSCompletionList in LSP scenarios. F5 Hot Reload (dotnet#52101) Fix typescript shim Add tests for lazy syntax trees coming from the GeneratorDriver React to code review feedback. Simplify the lazy-initalization pattern used in GetRoot Remove an unnecessary override. (dotnet#52140) Update issue number (dotnet#52130) Enable CodeActions support for XAML using its own provider and CodeActionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129) Add RestrictedIVT to dotnet watch to Features (dotnet#52087) Don't try to highlight operators (dotnet#52041) Use `null` instead of empty signature helps in LSP Use member type for relational pattern even in error cases (dotnet#51950) Update src/VisualStudio/Xaml/Impl/Implementation/LanguageServer/Extensions/SymbolExtensions.cs Use new QuickInfoUtilities helper Rebuild API shape (dotnet#52079) Added position parameter name Updated XAML QuickInfo to show more info like C# by using ISymbolDisplayService and adding more documentation parts. ...
No description provided.