For the purpose of runtime capability check require RuntimeFeature type to be a static class.#50829
Merged
AlekseyTs merged 1 commit intodotnet:masterfrom Jan 28, 2021
Merged
Conversation
…pe to be a static class. This avoids going into a cycle while trying to compile malformed declaration of the type. Fixes dotnet#50491.
Contributor
Author
|
@dotnet/roslyn-compiler Please review, need a second sign-off. |
333fred
reviewed
Jan 28, 2021
|
|
||
| internal bool RuntimeSupportsUnmanagedSignatureCallingConvention | ||
| => GetSpecialTypeMember(SpecialMember.System_Runtime_CompilerServices_RuntimeFeature__UnmanagedSignatureCallingConvention) is object | ||
| => RuntimeSupportsFeature(SpecialMember.System_Runtime_CompilerServices_RuntimeFeature__UnmanagedSignatureCallingConvention) |
Member
There was a problem hiding this comment.
(Not that I'm saying hold off, just that it's a race)
333fred
reviewed
Jan 28, 2021
| { | ||
| public static partial interface RuntimeFeature | ||
| { | ||
| public const string DefaultImplementationsOfInterfaces = nameof(DefaultImplementationsOfInterfaces); |
333fred
approved these changes
Jan 28, 2021
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jan 28, 2021
* upstream/master: For the purpose of runtime capability check require RuntimeFeature type to be a static class. (dotnet#50829) Allow mixed declaration and assignment in deconstruction (dotnet#44476) Disable sdl Fix crash around handling delegating of constructors cross-project Clarify in a comment when some stuff loads Don't reference the implementation type directly if we don't need it Remove the CreateWorkspace() method that implies it's created there Delete AbstractPackage`2.IsInIdeMode() Remove some very outdated comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids going into a cycle while trying to compile malformed declaration of the type.
Fixes #50491.