Enable tests that depend on the presence of unmanaged callers only in the runtime#50845
Merged
333fred merged 4 commits intodotnet:masterfrom Jan 28, 2021
Merged
Enable tests that depend on the presence of unmanaged callers only in the runtime#50845333fred merged 4 commits intodotnet:masterfrom
333fred merged 4 commits intodotnet:masterfrom
Conversation
… the runtime Now that we have .NET 5 in our test assemblies, we can enable tests that actually need it to run. Fixes dotnet#46676.
cston
reviewed
Jan 27, 2021
| Derived2 Stdcall, Stdcall, Thiscall ref return | ||
| "; | ||
|
|
||
| var allSourceComp = CreateCompilationWithFunctionPointers(@using + executableCode + source1 + source2, options: TestOptions.UnsafeReleaseExe); |
Contributor
There was a problem hiding this comment.
Consider passing as a collection of source: CreateCompilationWithFunctionPointers(new[] { executableCode, source1, ... }, ...).
cston
approved these changes
Jan 27, 2021
Contributor
|
It looks like there are CI failures. |
* upstream/master: For the purpose of runtime capability check require RuntimeFeature type to be a static class. (dotnet#50829) Allow mixed declaration and assignment in deconstruction (dotnet#44476) Disable sdl Fix crash around handling delegating of constructors cross-project Clarify in a comment when some stuff loads Don't reference the implementation type directly if we don't need it Remove the CreateWorkspace() method that implies it's created there Delete AbstractPackage`2.IsInIdeMode() Remove some very outdated comments
Member
|
Looks like the test failures are #50521. |
jaredpar
approved these changes
Jan 28, 2021
Member
Author
Aleksey was commenting on the test failures I had fixed locally but forgotten to push. |
Member
Author
|
@AlekseyTs I've addressed the test failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have .NET 5 in our test assemblies, we can enable tests that actually need it to run. Fixes #46676.