Fix mapping in razor x-file codespaces#49220
Merged
dibarbet merged 2 commits intodotnet:masterfrom Nov 10, 2020
Merged
Conversation
davidwengier
approved these changes
Nov 8, 2020
src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionResolveHandler.cs
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Extensions/ProtocolConversions.cs
Outdated
Show resolved
Hide resolved
9a4f24f to
0977eaf
Compare
dibarbet
added a commit
to dibarbet/roslyn
that referenced
this pull request
Nov 24, 2020
dibarbet
added a commit
that referenced
this pull request
Nov 24, 2020
Revert changes from #49220 to t…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #49216
Previously the text edits were not being remapped correctly as we were only mapping Locations and not TextDocumentEdits. This adds a function to properly convert from solution changes to LSP document edits.
cc @NTaylorMullen