Revert changes from https://github.com/dotnet/roslyn/pull/49220/ to t…#49592
Merged
dibarbet merged 1 commit intodotnet:release/dev16.9from Nov 24, 2020
Merged
Conversation
allisonchou
approved these changes
Nov 24, 2020
Member
Author
|
@jinujoseph I believe this will need approval since we just snapped |
davidwengier
approved these changes
Nov 24, 2020
Contributor
|
Thanks @dibarbet! |
NTaylorMullen
approved these changes
Nov 24, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…he code actions resolve handler
Issue:
Add @using code actions in razor local LSP do not work as C# hangs attempting to call the razor span mapping service.
Cause:
This was introduced by #49220 to support cross file rename in server scenarios to remap all workspace edits. As part of that PR I unified handling of workspace edits across all LSP functions which included code action resolve. However, calling razor to map during a code action will hang.
PR:
The change here is to revert the changes to codeAction/resolve workspace edit handling (the old implementation did not attempt to map spans). Cross file rename will still work since we are not reverting that part. Once the hang issue is fixed (tracked by https://github.com/dotnet/aspnetcore/issues/28102) we should revert this commit so that we have unified handling for workspace edits.