Skip to content

Fix crash, and offer "declare as nullable" for tuple fields#46437

Merged
davidwengier merged 4 commits intodotnet:masterfrom
davidwengier:OfferDeclareAsNullableForTupleFields
Jul 30, 2020
Merged

Fix crash, and offer "declare as nullable" for tuple fields#46437
davidwengier merged 4 commits intodotnet:masterfrom
davidwengier:OfferDeclareAsNullableForTupleFields

Conversation

@davidwengier
Copy link
Member

Fixes #46354

This fixes the crash, but also adds support to the fixer for tuple fields.

@davidwengier davidwengier requested a review from a team as a code owner July 30, 2020 00:39
@davidwengier davidwengier merged commit 400e9c3 into dotnet:master Jul 30, 2020
@ghost ghost added this to the Next milestone Jul 30, 2020
@davidwengier davidwengier deleted the OfferDeclareAsNullableForTupleFields branch July 30, 2020 23:17
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 31, 2020
* upstream/master: (304 commits)
  Tweak diagnostics to account for records (dotnet#46341)
  Diagnose precedence inversion in a warning wave (dotnet#46239)
  Remove PROTOTYPE tag (dotnet#45965)
  Only run a single pass of NullableWalker per-member (dotnet#46402)
  Fix crash, and offer "declare as nullable" for tuple fields (dotnet#46437)
  Simplify contract for RunWithShutdownBlockAsync
  Fix optprof plugin input
  check if EditorAdaptersFactoryService gives us a null buffer
  Cannot assign maybe-null value to TNotNull variable (dotnet#41445)
  Fix overload resolution to handle binary compat in the face of covariant returns (dotnet#46367)
  Same failure on Linux
  Skip some tests on Mac
  Added search option for inline parameter name hints
  Spelling
  tweak docs
  Improve comment
  Improve the "not exhaustive" diagnostic in the presence of a when clause. (dotnet#46143)
  PR feedback
  Use record keyword to display records (dotnet#46338)
  remove test that aserts .NET Standard should be prefered over .NET Framework
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'CSharpDeclareAsNullableCodeFixProvider' encountered an error and has been disabled

4 participants