Merged
Conversation
added 3 commits
June 3, 2020 11:40
This reverts commit 68fc0c8.
Contributor
|
Can you also update each of these line comments to include a link to the GitHub issue tracking the TODO? |
sharwell
reviewed
Jul 14, 2020
src/Workspaces/Core/Portable/Workspace/Solution/ProjectState.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Jul 14, 2020
| public bool NeedsFullGeneration { get; } | ||
|
|
||
| /* PROTOTYPE: re-enable when PendingEdit is public again | ||
| /* TODO: re-enable when PendingEdit is public again |
Contributor
There was a problem hiding this comment.
📝 This should use #if false instead of a block comment.
Contributor
Author
There was a problem hiding this comment.
Thanks, updated in the PR.
Contributor
Author
Tracked those PROTOTYPEs back to #42373. Can't seem to find the issues related to those comments though. |
Member
|
@chsienki do we have tracking items somewhere when we disabled the PendingEdit stuff? |
Contributor
|
@dotnet/roslyn-ide, please review. |
jasonmalinowski
approved these changes
Jul 30, 2020
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 31, 2020
* upstream/master: (304 commits) Tweak diagnostics to account for records (dotnet#46341) Diagnose precedence inversion in a warning wave (dotnet#46239) Remove PROTOTYPE tag (dotnet#45965) Only run a single pass of NullableWalker per-member (dotnet#46402) Fix crash, and offer "declare as nullable" for tuple fields (dotnet#46437) Simplify contract for RunWithShutdownBlockAsync Fix optprof plugin input check if EditorAdaptersFactoryService gives us a null buffer Cannot assign maybe-null value to TNotNull variable (dotnet#41445) Fix overload resolution to handle binary compat in the face of covariant returns (dotnet#46367) Same failure on Linux Skip some tests on Mac Added search option for inline parameter name hints Spelling tweak docs Improve comment Improve the "not exhaustive" diagnostic in the presence of a when clause. (dotnet#46143) PR feedback Use record keyword to display records (dotnet#46338) remove test that aserts .NET Standard should be prefered over .NET Framework ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace instances of
PROTOTYPEinCompiler.slncodebase withTODO, as the @dotnet/roslyn-compiler usesPROTOTYPEto track feature work.