add branch name to list of branches that trigger CI#45517
Merged
jmarolf merged 150 commits intodotnet:feature/convertNameOffrom Jun 29, 2020
Merged
add branch name to list of branches that trigger CI#45517jmarolf merged 150 commits intodotnet:feature/convertNameOffrom
jmarolf merged 150 commits intodotnet:feature/convertNameOffrom
Conversation
IParameterSymbol.DeclaringSyntaxReferences will be empty if the analyzed method call is targeting a method with no source code available (external assembly).
… accessors had no references
…he comment more comprehensive
All array types for one elemnt type is consider same in our index. e.g. int[], int[][] and int[,] are just represent as int[]
…reAsNullableCodeFixTests.cs
Since they are already from the same compilation that triggered completion.
…reAsNullableCodeFixTests.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>
…emantic diagnostics for a specific tree, which are categorized by each analyzer that reported the diagnostic. We have existing APIs on this type that return the same diagnostics, but as a single group instead of categorized by analyzer. Latter is required by the IDE analyzer host as we cache diagnostics from each analyzer.
Perf improvement for completion of unimported extension methods
Fix inconsistencies in handling CompilerVisibleItemMetadata
* Additional tests for nested function contexts. * Override VisitFunctionPointerLoad in MethodToClassRewriter. * Adjust debug asserts.
…626.2 (dotnet#45482) Microsoft.DotNet.Arcade.Sdk From Version 1.0.0-beta.20302.3 -> To Version 1.0.0-beta.20326.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
We have two members in TypeKind that point to the same value, Struct and Structure. Because of this, Enum.ToString(), which under the covers uses a binary search, isn't stable which one it will pick and it can change if other TypeKinds are added. This ensures we keep using the same string consistently. We also have a few members in MethodKind that are also duplicates, but it appears those have kept stable. To be safe, we now serialize explicitly. Fixes dotnet#44714
Function pointer bug fixes
Reduce memory required for document change processing queues
Update Language Feature Status
…n-inconsistency Fix up nondeterminism in serializing naming style preferences
* Move SymbolSearch down to EditorFeatures * RemoteControl package reference
…) in records with the latest design. (dotnet#45475) * Align addition of a synthesized override of object.Equals(object? obj) in records with the latest design. Related to dotnet#45296. From specification: The record type includes a synthesized override of object.Equals(object? obj). It is an error if the override is declared explicitly. The synthesized override returns Equals(other as R) where R is the record type.
JoeRobich
reviewed
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turning on continuous integration in this branch