Fix up nondeterminism in serializing naming style preferences#45483
Merged
jasonmalinowski merged 1 commit intodotnet:masterfrom Jun 27, 2020
Merged
Conversation
dibarbet
approved these changes
Jun 26, 2020
Member
dibarbet
left a comment
There was a problem hiding this comment.
Looks fine to me, one question though. If the enum represents the same thing, should we just stop producing one of them and deprecate it?
ryzngard
approved these changes
Jun 26, 2020
sharwell
approved these changes
Jun 26, 2020
...SharedUtilitiesAndExtensions/Compiler/Core/NamingStyles/Serialization/SymbolSpecification.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jun 26, 2020
Member
Author
@dibarbet: it's not that there's different entries, there's two entries with the same numeric value. Back in the days we apparently couldn't decide whether TypeKind (which is shared between C# and VB) should use the C# keyword name or the VB keyword name, so we chose "both" as the option and had two entries with the same numeric value. When you call ToString() the framework just has to pick one. |
mavasani
approved these changes
Jun 26, 2020
We have two members in TypeKind that point to the same value, Struct and Structure. Because of this, Enum.ToString(), which under the covers uses a binary search, isn't stable which one it will pick and it can change if other TypeKinds are added. This ensures we keep using the same string consistently. We also have a few members in MethodKind that are also duplicates, but it appears those have kept stable. To be safe, we now serialize explicitly. Fixes dotnet#44714
b728070 to
e93dca6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have two members in TypeKind that point to the same value, Struct and Structure. Because of this, Enum.ToString(), which under the covers uses a binary search, isn't stable which one it will pick and it can change if other TypeKinds are added. This ensures we keep using the same string consistently.
Fixes #44714