Stop generating InteractiveComponents VSIX#43208
Merged
tmat merged 4 commits intodotnet:masterfrom Apr 9, 2020
Merged
Conversation
Member
Author
|
@CyrusNajmabadi FYI |
CyrusNajmabadi
approved these changes
Apr 8, 2020
jasonmalinowski
approved these changes
Apr 9, 2020
...ualStudio/VisualStudioInteractiveComponents/Roslyn.VisualStudio.InteractiveComponents.csproj
Show resolved
Hide resolved
Contributor
|
Would love to get this in asap. It makes f5 debugging such a PITA. :) |
Member
Author
Your wish is granted. :) |
kzu
added a commit
to kzu/roslyn
that referenced
this pull request
Jun 14, 2020
Given we stopped generating the InteractiveComponents VSIX since dotnet#43208, we should not try to include it in the deployment VSIX either, since this then fails to install because of the missing payload.
Contributor
|
This broke the RoslynDeployment.vsix since now there's a dependency that's missing... I'm guessing testing feature branches using that isn't very popular ;). Fixed in #45159 . |
kzu
added a commit
to kzu/roslyn
that referenced
this pull request
Jun 15, 2020
This makes it more straightforward to stay up to date after an initial install of a dogfooding VSIX. This works in conjuction with the new VSIX feeds per feature branch, and removes the need to manually configure a private VS gallery feed. This works even when the VSIX is built locally, since a static pkgdef can be referenced in the VSIX manifest even if it's not present in the VSIX, in which case it will just be ignored. The MoreInfo and ReleaseNotes URLs are provided to point to the source commit and a comparison log for the branch too. Also, given we stopped generating the InteractiveComponents VSIX since dotnet#43208, we should not try to include it in the deployment VSIX either, since this then fails to install because of the missing payload.
kzu
added a commit
to kzu/roslyn
that referenced
this pull request
Jun 15, 2020
Given we stopped generating the InteractiveComponents VSIX since dotnet#43208, we should not try to include it in the deployment VSIX either, since this then fails to install because of the missing payload.
kzu
added a commit
to kzu/roslyn
that referenced
this pull request
Jun 15, 2020
This makes it more straightforward to stay up to date after an initial install of a dogfooding VSIX. This works in conjuction with the new VSIX feeds per feature branch, and removes the need to manually configure a private VS gallery feed. This works even when the VSIX is built locally, since a static pkgdef can be referenced in the VSIX manifest even if it's not present in the VSIX, in which case it will just be ignored. The MoreInfo and ReleaseNotes URLs are provided to point to the source commit and a comparison log for the branch too. Also, given we stopped generating the InteractiveComponents VSIX since dotnet#43208, we should not try to include it in the deployment VSIX either, since this then fails to install because of the missing payload.
kzu
added a commit
to kzu/roslyn
that referenced
this pull request
Jun 15, 2020
This makes it more straightforward to stay up to date after an initial install of a dogfooding VSIX. This works in conjuction with the new VSIX feeds per feature branch, and removes the need to manually configure a private VS gallery feed. This works even when the VSIX is built locally, since a static pkgdef can be referenced in the VSIX manifest even if it's not present in the VSIX, in which case it will just be ignored. The MoreInfo and ReleaseNotes URLs are provided to point to the source commit and a comparison log for the branch too. Also, given we stopped generating the InteractiveComponents VSIX since dotnet#43208, we should not try to include it in the deployment VSIX either, since this then fails to install because of the missing payload.
This was referenced Jun 15, 2020
tmat
pushed a commit
that referenced
this pull request
Jun 3, 2022
Given we stopped generating the InteractiveComponents VSIX since #43208, we should not try to include it in the deployment VSIX either, since this then fails to install because of the missing payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34002