Stop attempting to include InteractiveComponents VSIX#45159
Merged
tmat merged 1 commit intodotnet:mainfrom Jun 3, 2022
Merged
Conversation
Given we stopped generating the InteractiveComponents VSIX since dotnet#43208, we should not try to include it in the deployment VSIX either, since this then fails to install because of the missing payload.
Contributor
Author
Contributor
|
@tmat What should we do with this PR? Thanks! |
tmat
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given we stopped generating the InteractiveComponents VSIX
since #43208, we should not try to include it in the deployment
VSIX either, since this then fails to install because of the
missing payload.
Fixes #45327