Skip to content

Merge release/dev16.5 to release/dev16.5-vs-deps#41436

Merged
55 commits merged intorelease/dev16.5-vs-depsfrom
merges/release/dev16.5-to-release/dev16.5-vs-deps
Feb 5, 2020
Merged

Merge release/dev16.5 to release/dev16.5-vs-deps#41436
55 commits merged intorelease/dev16.5-vs-depsfrom
merges/release/dev16.5-to-release/dev16.5-vs-deps

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is an automatically generated pull request from release/dev16.5 into release/dev16.5-vs-deps.

git fetch --all
git checkout merges/release/dev16.5-to-release/dev16.5-vs-deps
git reset --hard upstream/release/dev16.5-vs-deps
git merge upstream/release/dev16.5
# Fix merge conflicts
git commit
git push upstream merges/release/dev16.5-to-release/dev16.5-vs-deps --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

svick and others added 30 commits August 31, 2019 18:38
Drawbacks:
* Only covers cases where the invocation is nested within an executable statement
* Performs abysmally due to creating a whole speculative semantic model for the vast majority of invocations, and additionally using GetOperation which is quite slow in general

At some point amongst all the code that runs there is presumably a crucial function which has the rules for binding a name-type syntax into an invocation.
Ideally we'd find a way to call just that function here on invocationExpression.Expression
(even without an arg list)

It's possible there are some other cases when VB will happily invoke something without an arg list, but since i can't find the relevant spec or code, I'm erring on the side of caution
…ionTests.vb

Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
Therefore we can't know it's safe to remove parentheses since it could be a delegate
This is to allow "TestInsertCallIfNecessary3()" to continue to pass.
Note that the test result isn't fully simplified since it says:
Call (Sub() Exit Sub)
instead of
Call Sub() Exit Sub
This is outside the scope of this PR
There is no parameterless Console.Write hence it doesn't resolve, and Program doesn't exist in the context at all
Don't think it's worth considering CandidateSymbols since they won't always be correct

Expanding and reducing stuff that doesn't compile sounds generally risky. In a future PR perhaps the expander shouldn't add the parentheses if it can't resolve the symbol.
If it wasn't invokable it wouldn't be valid at this point
…rmed" XML comments contain superfluous /// markers for every line-break in the original comment.
allisonchou and others added 18 commits January 31, 2020 15:30
Fix issues in MetadataAsSource XML documentation comment conversion
* Fix Pythia pooled objects wrappers

* Fix RPC
Fix for Visual Studio crashes when adding a parameter to a function
…cation-arglist

Stop Simplifier.ReduceAsync removing empty arg lists from delegates
* Set TEMP environment variable to $TempDir on CI machines

dotnet/arcade#4744 reverted setting the variable in `tools.ps1` due to issues it caused in other repos.
Annotate implementations of ILabelSymbol
Annotate implementations of IEventSymbol
Allow -launch to be used without -build
Preserve "unsafe" when refactoring between properties and methods
* MethodSymbol and FieldSymbol equality fixes:
 - Defer the equality of method/field symbol to the substituted symbol when compared
 - Make the hashcode of substituted method/field defer to the original definition
…losed-files

Run naming styles on closed files
Update arcade to support SDK publishing
@dotnet-bot dotnet-bot requested review from a team as code owners February 5, 2020 20:08
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Feb 5, 2020
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit bda5cd0 into release/dev16.5-vs-deps Feb 5, 2020
@ghost ghost deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 5, 2020 23:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.