Rename from IncludeNonNullableReferenceTypeModifier to IncludeNotNull…#41332
Merged
jcouv merged 1 commit intodotnet:masterfrom Feb 3, 2020
Merged
Rename from IncludeNonNullableReferenceTypeModifier to IncludeNotNull…#41332jcouv merged 1 commit intodotnet:masterfrom
jcouv merged 1 commit intodotnet:masterfrom
Conversation
…ableReferenceTypeModifier
cston
approved these changes
Jan 31, 2020
sharwell
reviewed
Jan 31, 2020
| @@ -71,6 +71,6 @@ public enum SymbolDisplayMiscellaneousOptions | |||
| /// <summary> | |||
| /// Append '!' to non-nullable reference types. | |||
Contributor
There was a problem hiding this comment.
Do we care about this one?
Member
Author
There was a problem hiding this comment.
No, I think this is correct. That's how the spec describes such types:
The non_nullable_reference_type in a nullable_reference_type must be a non-nullable reference type (class, interface, delegate or array), or a type parameter that is constrained to be a non-nullable reference type (through the class constraint, or a class other than object).
Member
Author
|
@333fred for another review. Tiny PR to address feedback from API review. Thanks |
333fred
approved these changes
Feb 3, 2020
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Feb 6, 2020
* dotnet/master: (918 commits) Pure null test on unconstrained type (dotnet#41384) Fix file headers, bootsrap build issues. Make `elementLocations` accept an array of nullable locations in the public api. Learn from non-null tests on as operator (dotnet#41419) Use Microsoft.NET.Sdk.WindowsDesktop for XAML projects (dotnet#40234) Address feedback. Introduce `GetRequiredBinder`. Add missing `NotNullWhen` annotations. Annotate more of the binder Add version of zlib library to deterministic build inputs (dotnet#41385) [master] Update dependencies from dotnet/arcade (dotnet#41354) Simplify Simplify Do not simplify interpolation expressions on implicit receivers. Fix local function crash + add tests Substituted symbol equality (dotnet#41123) Fix test failures Rename from IncludeNonNullableReferenceTypeModifier to IncludeNotNullableReferenceTypeModifier (dotnet#41332) Set TEMP environment variable to $TempDir on CI machines (dotnet#41361) Document placeholders ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ableReferenceTypeModifier
Per API review