Run naming styles on closed files#37287
Conversation
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Approve
Submit feedback approving these changes.
|
@jasonmalinowski Any progress on this one? There is a VS feedback user request to view all naming violations in a project/solution which depends on this PR. |
|
Another VS feedback requesting naming violations on closed files: https://developercommunity.visualstudio.com/content/problem/880060/vs2019-naming-rules-applied-inconsistently.html @jasonmalinowski Any update on this PR? |
1356223 to
618598a
Compare
Our best guess is we ran naming styles on open files only for two reasons: 1. At the time, we only supported .editorconfig in-proc, so out of proc wouldn't have used the right settings. 2. Even if we were running in-proc, there might have been performance issues since we were running across a lot of files. Neither of these concerns apply at this point: we now support .editorconfig out of proc (both in the legacy path and the new path) and since we're already running other analyzers that use .editorconfig, the cost of processing it will exist regardless.
618598a to
b4cc326
Compare
|
RPS run passed internally, which is what @sharwell suspected since this is unlikely running in that scenario in the first place. |
|
Nope, looks all good to merge. Thanks Jason! |
|
OMG - thank-you thank-you thank-you! |
|
So glad this made the cutoff! |
|
You should also be able to get advantage of this feature with "Open Document" analysis scope + invoking "Run Code Analysis" command on project/solution for an demand explicit execution. |
Our best guess is we ran naming styles on open files only for two reasons:
Neither of these concerns apply at this point: we now support .editorconfig out of proc (both in the legacy path and the new path) and since we're already running other analyzers that use .editorconfig,
the cost of processing it will exist regardless.
Fixes #15760