Introduce explicit downcast refactoring if a variable requires a cast to compile#41371
Merged
y87feng merged 98 commits intodotnet:masterfrom Mar 16, 2020
Merged
Introduce explicit downcast refactoring if a variable requires a cast to compile#41371y87feng merged 98 commits intodotnet:masterfrom
y87feng merged 98 commits intodotnet:masterfrom
Conversation
src/EditorFeatures/CSharpTest/Diagnostics/AddExplicitCast/AddExplicitCastTests.cs
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/Diagnostics/AddExplicitCast/AddExplicitCastTests_FixAllTests.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
suggested changes
Feb 3, 2020
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
lots of safety concerns. but a great start!
Contributor
|
Hi @y87feng ! Thanks for the contribution. Overall this is a great start. The primary things we'll need here are good docs in teh code explaining why what it is doing is correct (as it's not self evident), as well as a lot of beefing up the safety of hte feature. i.e. the code currently makes a ton of assumptions about the results it may get back from certain calls. This is not safe and may absolutely crash in existin code scenarios (or future changes as the compiler/langauge moves forward). I'm happy to help out with more information on this if you need it! |
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Show resolved
Hide resolved
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
A lot nicer! Needs some comments in code to help with things, and some small refactoring. But overall very close!
…icitCastCodeFixProvider.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Mar 13, 2020
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Looks fantastic! 📦
…icitCastCodeFixProvider.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…icitCastCodeFixProvider.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
Contributor
|
Congratulations! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented code fix for error code: CS0266, CS1503
Issue link: #40967