bug fix for https://github.com/dotnet/roslyn/pull/41371#42487
Merged
y87feng merged 3 commits intodotnet:masterfrom Mar 17, 2020
Merged
bug fix for https://github.com/dotnet/roslyn/pull/41371#42487y87feng merged 3 commits intodotnet:masterfrom
y87feng merged 3 commits intodotnet:masterfrom
Conversation
Contributor
|
Please include a description for future people to learn in the git log :) |
ryzngard
approved these changes
Mar 17, 2020
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
LGTM assuming CI builds pass
RikkiGibson
reviewed
Mar 17, 2020
src/Features/CSharp/Portable/CodeFixes/AddExplicitCast/AddExplicitCastCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
approved these changes
Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#41371 failed CI tests with error
CS8762: Parameter 'targetArgumentConversionType' may not have a null value when exiting with 'true'.on fileAddExplicitCastCodeFixProvider.csline 335