Merge master to features/param-nullchecking#36558
Merged
11 commits merged intofeatures/param-nullcheckingfrom Jun 19, 2019
Merged
Merge master to features/param-nullchecking#3655811 commits merged intofeatures/param-nullcheckingfrom
11 commits merged intofeatures/param-nullcheckingfrom
Conversation
…)" This reverts commit ff0359d.
…ullability I added a test to ensure the inferrer no longer crashes, but #36046 still blocks the ability for it to actually pass. The test is then added skipped until that works.
We had two overloads of AbstractSymbolCompletionProvider.CreateItems, once which handles the case of a single file and one that handles linked files. The code is almost identical, but the linked file one incorrectly handled the case of not having any symbols. Rather than fixing the bug in just that branch, I'm refactoring it to simply remove the second copy so both the single file and linked file cases go through the same helper. The intent here is to avoid hiding simple bugs that had nothing to do with linked files in the linked-file-only path. Fixes #36080 by virtue of deleting the offending code entirely. No new tests are added since I've confirmed that the existing tests (once the refactoring was complete) would have been sufficient for discovering this problem.
Fix #36060: Group Completion Providers using IsExclusive
…with-method-inference Fix crash where type inference doing method inference needs to drop nullability
Revert 35746
…-fatal-watson Remove duplication in AbstractSymbolCompletionProvider.CreateItems
Member
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/param-nullchecking.
git fetch --all git checkout merges/master-to-features/param-nullchecking git reset --hard upstream/features/param-nullchecking git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/param-nullchecking --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.