Fix crash where type inference doing method inference needs to drop nullability#36517
Merged
jasonmalinowski merged 1 commit intodotnet:masterfrom Jun 18, 2019
Conversation
…ullability I added a test to ensure the inferrer no longer crashes, but dotnet#36046 still blocks the ability for it to actually pass. The test is then added skipped until that works.
Member
Author
|
I had done a pass across the type inference service and had mis-interpreted that we didn't need to update this. It looks we didn't actually have any tests covering this scenario? |
ryzngard
approved these changes
Jun 17, 2019
Member
Author
|
Tagging @jinujoseph for M2 approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a test to ensure the inferrer no longer crashes, but #36046 still blocks the ability for it to actually pass. The test is then added skipped until that works.