Lower expressions of in arguments to correct temp locals#28181
Merged
OmarTawfik merged 1 commit intodotnet:masterfrom Jul 2, 2018
OmarTawfik:bugs/27831/in-async-lowering
Merged
Lower expressions of in arguments to correct temp locals#28181OmarTawfik merged 1 commit intodotnet:masterfrom OmarTawfik:bugs/27831/in-async-lowering
OmarTawfik merged 1 commit intodotnet:masterfrom
OmarTawfik:bugs/27831/in-async-lowering
Conversation
Contributor
Author
|
@dotnet/roslyn-compiler for review. #Closed |
cston
reviewed
Jul 2, 2018
| } | ||
|
|
||
| [Fact] | ||
| [WorkItem(27831, "https://github.com/dotnet/roslyn/issues/27831")] |
Contributor
There was a problem hiding this comment.
Is this test related to the bug or the code change? If not, consider removing [WorkItem]. #Resolved
Contributor
Author
There was a problem hiding this comment.
I'd say yes. The [WorkItem] would help to point why the test was added (negative and positive case below).
In reply to: 199562472 [](ancestors = 199562472)
cston
approved these changes
Jul 2, 2018
Contributor
Author
|
@jaredpar for merge approval. |
Member
|
approved for merge |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 11, 2018
…atures/compiler * dotnet/features/compiler: (137 commits) Actually fix tabs. Added back breaking changes doc. Addressed PR feedback. Track enclosing symbol in data flow analysis, which might be a field or property. (dotnet#28252) Change text from 'Spell check' to 'Fix typo'. Implement FAR for GetAwaiter methods (dotnet#28230) Fix typo Fix typo Fix import. Address PR feedback and fix failing test. Lower expressions of in arguments to correct temp locals (dotnet#28181) Move to 2.0.7 runtime Produce errors on ref-assignment to non-ref parameters Fix spelling. Preserve left-to-right evaluation order for dynamic compound addition and subtraction. inline. Provide a spellchecking suggestion when someone mispells a constructor. Typo (dotnet#28177) PR Comments Fix regression in bitness of Interactive Window host (dotnet#28006) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27831