Fix regression in bitness of Interactive Window host#28006
Fix regression in bitness of Interactive Window host#28006tmat merged 6 commits intodotnet:masterfrom
Conversation
|
@dotnet/roslyn-interactive @ivanbasov Please review. |
| { | ||
| bool initialize; | ||
| if (!TryParseArguments(arguments, out initialize)) | ||
| if (!TryParseArguments(arguments, out bool initialize, out bool? is64bit)) |
There was a problem hiding this comment.
bool [](start = 71, length = 4)
I think that enum would be better for the case.
There was a problem hiding this comment.
How would that enum items be named?
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
32 is not a valid identifier
There was a problem hiding this comment.
There was a problem hiding this comment.
Bit32 is odd. I have thought about this and didn't come up with any good names, so I used bool?.
We need both {32, 64} and {32, 64, default} types.
There was a problem hiding this comment.
I see. Other then that, I do not have any comments. I still would prefer to reconsider "bool? Is64Bit" because it looks counterintuitive.
You can decide but please re-consider it once again.
In reply to: 198258202 [](ancestors = 198258202)
|
test windows_debug_vs-integration_prtest please |
|
test windows_debug_vs-integration_prtest please |
|
test windows_release_vs-integration_prtest please |
|
test windows_debug_vs-integration_prtest please |
|
test windows_release_vs-integration_prtest please |
|
test windows_debug_vs-integration_prtest please |
|
test windows_release_vs-integration_prtest please |
1 similar comment
|
test windows_release_vs-integration_prtest please |
|
@jinujoseph For 15.8 approval |
|
Approved to merge for 15.8.Preview5 |
…atures/compiler * dotnet/features/compiler: (137 commits) Actually fix tabs. Added back breaking changes doc. Addressed PR feedback. Track enclosing symbol in data flow analysis, which might be a field or property. (dotnet#28252) Change text from 'Spell check' to 'Fix typo'. Implement FAR for GetAwaiter methods (dotnet#28230) Fix typo Fix typo Fix import. Address PR feedback and fix failing test. Lower expressions of in arguments to correct temp locals (dotnet#28181) Move to 2.0.7 runtime Produce errors on ref-assignment to non-ref parameters Fix spelling. Preserve left-to-right evaluation order for dynamic compound addition and subtraction. inline. Provide a spellchecking suggestion when someone mispells a constructor. Typo (dotnet#28177) PR Comments Fix regression in bitness of Interactive Window host (dotnet#28006) ...
Customer scenario
Customer uses Initialize Interactive from Project command on a project that has a 32-bit native dependency. The dependencies fail to load since the host process is 64-bit. This is a regression from previous VS version where the process was 32-bit.
Simply switching back to 32-bit would fix the regression but won't help our customers who use interactive to work with 64-bit native libraries or huge data sets. This change therefore adds an optional parameter to
#resetcommand that allows to specify the desired bitness:#reset 32and#reset 64set the bitness accordingly, while#resetwithout the argument preserves the current bitness for the new process instance. In addition, Initialize Interactive from Project feature sets the bitness based on the target platform of the project. We also now display the bitness in the title of the Interactive Window, so that it's clear which bitness is the active one.Bugs this fixes
VS Feedback
#7663
Workarounds, if any
No workaround.
Risk
Small.
Performance impact
None.
Is this a regression from a previous update?
Root cause analysis
Missing test coverage.
How was the bug found?
Reported by multiple customers.
Test documentation updated?