Merging master into features/embeddedRegex#25918
Merged
jmarolf merged 119 commits intodotnet:features/embeddedRegexfrom Apr 4, 2018
Merged
Merging master into features/embeddedRegex#25918jmarolf merged 119 commits intodotnet:features/embeddedRegexfrom
jmarolf merged 119 commits intodotnet:features/embeddedRegexfrom
Conversation
…a declaration pattern
This change ensures that all work added to the work queue after disconnection is immediately cancelled.
While it doesn't make sense to still be requesting foreground actions after cancellation is requested, tracking down all callers of IForegroundNotificationService to ensure the proper checks are in place can be tedious. This change treats IForegroundNotificationService as the gatekeeper for scheduling asynchronous operations, and proactively cancels operations if requested before adding them to the work queue.
Isolate tests
Update links to Samples.sln location
Merge dev15.7.x to master
…lass (dotnet#25238) (dotnet#25866) * * Generate Constructor should not copy "protected" from abstract base class (dotnet#25238) * Changed accessibility, created VB tests (dotnet#25238) * Changes after code review.
Move Roslyn.sln to newer analyzers (with Dispose rules disabled)
Adding missing completion for switch when clause
UseDefaultLiteral and RemoveUnnecessaryCast shouldn't introduce invalid default literal in pattern or case label
Contributor
Author
|
Tagging @jcouv . Simple merge of master into features/embeddedRegex. I don't want these branches to fall far behind :) |
Contributor
Author
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.