Merged
Conversation
…vider in a test constructor
This addresses a code review feedback point from #25558.
In the case the CLI was previously downloaded but not yet on `%PATH%` we need to manually add it there. Not doing it leads to cases where MSBuild can't find the proper SDK and as a result failing the build. closes #25649
…or local functions, and exposed both to IOperation consumers.
…n specified in review.
The static constructor of SQLitePersistentStorage would throw an exception, which would then get logged by the exception logger. This changes the following logic: * The database used to be deleted if e_sqlite was not found. * The sqlite persistent storage is not used if e_sqlite is not found. * The database ownership lock is released if any exceptions happen while trying to instantiate the storage. Fixes #24042 Extra story: There is a architectures of e_sqlite not existing for some platforms, i.e. ARM64. Therefore, in MonoDevelop, it would throw a TypeInitializationException on trying to initialize the SQLitePersistentStorage. In this case, what would happen is: * The persistent storage service would create the lock file. * It would throw in the static constructor, without having passed ownership * Thus, the lock file is created by the service, not held by anyone specifically * The exception wasn't accounted for, so the storage file would be deleted * We now have a lock file present and no storage created * Roslyn will keep trying to create the persistent storage on every subsequent try, ending up in a performance issue caused by continuous IO on trying to get ownership on the lock file, but it can't take it because nobody released the old lock Therefore, shortcircuiting and disabling persistent storage in case the lib is not found is better.
Fix signing of swix project output
The implementations of ISuggestedAction use threading assertions instead of automatic transition to the correct thread, placing the burden of correct thread selection on the caller, TextViewWindow_InProc. This change switches to the vs-threading approach for maintaining thread affinity, which has two parts: 1. When entering thread-affinitized code, switch to the correct thread 2. Avoid using ConfigureAwait(false) to lose the required affinity The entire file relies on the default behavior of ConfigureAwait, which is the normal coding practice in asynchronous code following vs-threading patterns.
Make escape analysis over unexpected nodes to return conservative results
Further work to stabilize the integration test interop layer
The getter is 'Enabled' and the setter is 'SetEnabled_OnlyUseExportProviderAttributeCanCall'.
This change ensures that all work added to the work queue after disconnection is immediately cancelled.
While it doesn't make sense to still be requesting foreground actions after cancellation is requested, tracking down all callers of IForegroundNotificationService to ensure the proper checks are in place can be tedious. This change treats IForegroundNotificationService as the gatekeeper for scheduling asynchronous operations, and proactively cancels operations if requested before adding them to the work queue.
Isolate tests
Implements targets that calculate PathMap from SourceRoots and provide extension point for Source Link generator
sharwell
suggested changes
Apr 2, 2018
Contributor
sharwell
left a comment
There was a problem hiding this comment.
Currently investigating a possible integration test hang introduced in the merge.
d6a0d89 to
98d68f9
Compare
sharwell
approved these changes
Apr 2, 2018
Contributor
|
@jasonmalinowski We can either wait for #25892, or move his forward and catch it in the next update |
Member
|
@sharwell Unless we believe there is new flakiness due to this merge, we shouldn't block these on flakiness. |
Contributor
|
@jasonmalinowski This change fixes a bunch of flakiness but introduces the cleanup timeout flakiness. Unless master has been reliable recently this is probably a net win even without the referenced PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev15.7.x into master.
git fetch --all git checkout merges/dev15.7.x-to-master git reset --hard upstream/master git merge upstream/dev15.7.x # Fix merge conflicts git commit git push merges/dev15.7.x-to-master --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.