Skip to content

Do not extract component into code block#11069

Merged
ryzngard merged 3 commits intodotnet:mainfrom
ryzngard:extractcomponent_incodeblock
Oct 23, 2024
Merged

Do not extract component into code block#11069
ryzngard merged 3 commits intodotnet:mainfrom
ryzngard:extractcomponent_incodeblock

Conversation

@ryzngard
Copy link
Copy Markdown
Contributor

Fixes #11050

Commit by commit will show moving things around to clean up. Decided for now that the extraction should not be offered until we find a need/use case for it.

@ryzngard ryzngard requested a review from a team as a code owner October 23, 2024 00:06
@ryzngard ryzngard enabled auto-merge (squash) October 23, 2024 00:50
@ryzngard ryzngard merged commit 56c7427 into dotnet:main Oct 23, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 23, 2024
333fred added a commit to 333fred/razor that referenced this pull request Oct 23, 2024
* upstream/main: (290 commits)
  Add breaking changes document (dotnet#11064)
  Do not extract component into code block (dotnet#11069)
  Fix invalid setttings json (dotnet#11062)
  update MicrosoftSourceBuildIntermediatearcadePackageVersion
  Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512
  Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512
  Update source-build team references (dotnet#11032)
  Handle EditorRequired *Changed/*Expression parameters (dotnet#11043)
  Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213
  Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213
  Avoid ambiguous `object` reference in generic component recovery (dotnet#11053)
  Move culture info check (dotnet#11057)
  Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20241015.1
  Fix code actions integration tests
  Add option for format on paste (dotnet#11039)
  Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs
  Fix merge to 17.12 version
  Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs
  Ensure model directives are mapped at runtime (dotnet#11007)
  Fix @inherits mapping for fuse (dotnet#10985)
  ...
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.13 P1 Oct 31, 2024
davidwengier added a commit that referenced this pull request Oct 31, 2024
Fixes #11049

Turns out #11069 meant the ordering
of Razor and C# code actions is no longer a problem, so all we need to
do is make sure the code actions that introduce new `@using` directives
comes first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract component offered inside @code block

3 participants