Add option for format on paste#11039
Conversation
|
|
||
| if (formatOnType) | ||
| { | ||
| return FormattingFlags.All; |
There was a problem hiding this comment.
Why isn't this FormattingFlags.OnType ?
There was a problem hiding this comment.
I guess it would be FormattingFlags.Enabled | FormattingFlags.OnType but I didn't add something for paste
davidwengier
left a comment
There was a problem hiding this comment.
You beat me to it! Thank you <3
| parsedEnableFormatting is not null) | ||
| { | ||
| enableFormatting = GetObjectOrDefault(parsedEnableFormatting, enableFormatting); | ||
| formatting = GetObjectOrDefault(parsedEnableFormatting, formatting); |
There was a problem hiding this comment.
Shouldn't this still be parsed as a bool, and then converted to FormattingFlags.Enabled as necessary? Or are you planning on changing the VS Code option?
There was a problem hiding this comment.
doi, yes. Just blanket chnaging things. Should still be a bool in vs code
This reverts commit 019b7c8.
This reverts commit 019b7c8.
* upstream/main: (290 commits) Add breaking changes document (dotnet#11064) Do not extract component into code block (dotnet#11069) Fix invalid setttings json (dotnet#11062) update MicrosoftSourceBuildIntermediatearcadePackageVersion Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512 Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512 Update source-build team references (dotnet#11032) Handle EditorRequired *Changed/*Expression parameters (dotnet#11043) Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213 Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213 Avoid ambiguous `object` reference in generic component recovery (dotnet#11053) Move culture info check (dotnet#11057) Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20241015.1 Fix code actions integration tests Add option for format on paste (dotnet#11039) Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs Fix merge to 17.12 version Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs Ensure model directives are mapped at runtime (dotnet#11007) Fix @inherits mapping for fuse (dotnet#10985) ...
|
This supposedly was released in 17.13, but it flat-out doesn't work, at all. See the feedback: |
|
Thanks for posting @michaelcsikos, I agree this doesn't seem to work for me in 17.13 either. I'll reopen the GitHub issue |
Fixes #7025