Support multi-line Exec Commands #4213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an end-to-end test using `loadProjectReadOnly` and a multiline `Exec` task.
5519e11 to
6e4048e
Compare
Member
Author
|
fyi @jeffkl |
Contributor
|
|
nguerrera
approved these changes
Mar 7, 2019
Works around a behavior difference between XmlReader and XmlTextReader that caused newlines in attributes to be ignored in command-line builds. Fixes dotnet#4210.
a4b500d to
873c127
Compare
ladipro
added a commit
that referenced
this pull request
Apr 27, 2021
Fixes #2576 ### Context The code already has support for parsing project files as read-only when we know that we're not going to be asked to write them back to disk. This flag is currently unused because the initial implementation in #3584 introduced a regression related to whitespace in attribute values (#4210). ### Changes Made Trivially reverted part of #4213 that addressed the regression and added a hack to make `XmlReader` behave the same as `XmlTextReader`. ### Testing Existing unit tests for correctness and ETW for performance. `XmlDocumentWithLocation.Load()` is ~26% faster with this change compared to baseline when building .NET Core projects. This translates to about 10 ms per one incremental CLI build of a Hello world application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4210 by reverting to the old behavior of always using
XmlTextReader. I didn't just revert #3584 because that would be a public API change, and it seems better to avoid that churn this close to release. With this PR, the read-only option is ignored.