Load all projects as read-only in MSBuild.exe #3584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DesignTimeBuild Time (ms) (src\msbuild vs src\msbuild.jeff)
DesignTimeBuild Memory (bytes) (src\msbuild vs src\msbuild.jeff)
SerialEvaluationIsolatedContext Time (ms) (src\msbuild vs src\msbuild.jeff)
SerialEvaluationIsolatedContext Memory (bytes) (src\msbuild vs src\msbuild.jeff)
SerialEvaluationSharedContextSecondRun Time (ms) (src\msbuild vs src\msbuild.jeff)
SerialEvaluationSharedContextSecondRun Memory (bytes) (src\msbuild vs src\msbuild.jeff)
SerialEvaluationSharedContext Time (ms) (src\msbuild vs src\msbuild.jeff)
SerialEvaluationSharedContext Memory (bytes) (src\msbuild vs src\msbuild.jeff)
|
cdmihai
approved these changes
Aug 9, 2018
rainersigwald
requested changes
Aug 14, 2018
Member
rainersigwald
left a comment
There was a problem hiding this comment.
Waiting on the breaking(?) change.
Member
There was a problem hiding this comment.
Isn't this a breaking change? IIRC optional arguments are compiled into the consumer, so they can't be added without breaking and you have to add an overload instead.
src/Build/Xml/XmlReaderExtension.cs
Outdated
Contributor
Author
|
@AndyGerlicher do the perf numbers indicate if this change is worth it? I can't decipher them... |
Contributor
Author
Member
|
Really hard to tell - do you trust those numbers at all? It shows a large reduction in design-time build memory, but then regresses SerialEvaluationSharedContextSecondRun memory whatever that's doing. |
AndyGerlicher
approved these changes
Aug 28, 2018
rainersigwald
approved these changes
Aug 28, 2018
sidiesen
pushed a commit
to sidiesen/msbuild
that referenced
this pull request
Oct 4, 2018
Uses XmlReaderSettings to ignore comments and whitespace for all projects. At the moment we read comments but then report the content as just String.Empty. The XmlReader still allocates a string for us which we immediately throw away. This change adds a setting to ProjectCollection so that all projects loaded in the collection are treated as read-only. For command-line builds, a ProjectCollection is created for the build episode. End-users can create their own ProjectCollection with the setting as well. Fixes dotnet#2576
This was referenced Mar 5, 2019
ladipro
added a commit
that referenced
this pull request
Apr 27, 2021
Fixes #2576 ### Context The code already has support for parsing project files as read-only when we know that we're not going to be asked to write them back to disk. This flag is currently unused because the initial implementation in #3584 introduced a regression related to whitespace in attribute values (#4210). ### Changes Made Trivially reverted part of #4213 that addressed the regression and added a hack to make `XmlReader` behave the same as `XmlTextReader`. ### Testing Existing unit tests for correctness and ETW for performance. `XmlDocumentWithLocation.Load()` is ~26% faster with this change compared to baseline when building .NET Core projects. This translates to about 10 ms per one incremental CLI build of a Hello world application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
XmlReaderSettingsto ignore comments and whitespace for all projects. At the moment we read comments but then report the content as justString.Empty. TheXmlReaderstill allocates a string for us which we immediately throw away.This change adds a setting to
ProjectCollectionso that all projects loaded in the collection are treated as read-only. For command-line builds, a ProjectCollection is created for the build episode. End-users can create their own ProjectCollection with the setting as well.Fixes #2576