Skip to content

Tell Copilot not to allow breaking changes#13200

Merged
YuliiaKovalova merged 1 commit intomainfrom
copilot-breaking-change
Feb 5, 2026
Merged

Tell Copilot not to allow breaking changes#13200
YuliiaKovalova merged 1 commit intomainfrom
copilot-breaking-change

Conversation

@rainersigwald
Copy link
Copy Markdown
Member

Defense in depth for problems like the one that led to #13184 which led to broken VS Canary users.

@rainersigwald rainersigwald self-assigned this Feb 4, 2026
@rainersigwald rainersigwald requested a review from a team as a code owner February 4, 2026 17:13
Copilot AI review requested due to automatic review settings February 4, 2026 17:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds critical guidance to the Copilot instructions file to prevent breaking changes like the one that occurred in #13184, which required a revert after breaking VS Canary users. The addition emphasizes that MSBuild's critical role in the build ecosystem requires extreme caution with any changes that could break existing builds, particularly new errors or warnings.

Changes:

  • Adds a new "Breaking Changes" section to .github/copilot-instructions.md explaining the policy against adding new errors or warnings to existing behavior
  • Clarifies that warnings are breaking changes because many production builds use /WarnAsError
  • Provides an exception for new, opt-in behavior where warnings and errors can be added more freely

Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that

@YuliiaKovalova YuliiaKovalova merged commit 210eba4 into main Feb 5, 2026
15 checks passed
@YuliiaKovalova YuliiaKovalova deleted the copilot-breaking-change branch February 5, 2026 10:33
JanProvaznik pushed a commit to JanProvaznik/msbuild that referenced this pull request Feb 25, 2026
Defense in depth for problems like the one that led to dotnet#13184 which led
to broken VS Canary users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants